Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Audit and streamline CONTRIBUTING.md #5595

Merged
merged 3 commits into from Oct 2, 2022

Conversation

santoshyadavdev
Copy link
Contributor

@santoshyadavdev santoshyadavdev commented Sep 3, 2022

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Sep 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fdbffd3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @santoshyadavdev!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 3, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fdbffd3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63392e64137f95000951f8bc
😎 Deploy Preview https://deploy-preview-5595--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@santoshyadavdev
Copy link
Contributor Author

santoshyadavdev commented Sep 3, 2022

Hi Team, do we have any discord server?

FYI: the doc changes are inspired by https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for sending this in @santoshyadavdev!

You make some good suggestions. I'll go through and do another pass after this PR too - been thinking about it off-and-on...

return {
collapsed,
collapsible: collapsed,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving the sidebar changes for #5554 to another PR? That way we can get them in sooner - and it's easier to keep track when it's one-issue-per-PR.

CONTRIBUTING.md Outdated
Comment on lines 130 to 160

## Financial contributions

We also welcome financial contributions in full transparency on our [open collective](https://opencollective.com/typescript-eslint).
Anyone can file an expense. If the expense makes sense for the development of the community, it will be "merged" in the ledger of our open collective by the core contributors and the person who filed the expense will be reimbursed.

### Contributors

Thank you to all the people who have already contributed to typescript-eslint!
<a href="https://github.com/typescript-eslint/typescript-eslint/graphs/contributors"><img src="https://opencollective.com/typescript-eslint/contributors.svg?width=890" /></a>

### Backers

Thank you to all our backers! [[Become a backer](https://opencollective.com/typescript-eslint#backer)]

<a href="https://opencollective.com/typescript-eslint#backers" target="_blank"><img src="https://opencollective.com/typescript-eslint/backers.svg?width=890"></a>

### Sponsors

Thank you to all our sponsors! (please ask your company to also support this open source project by [becoming a sponsor](https://opencollective.com/typescript-eslint#sponsor))

<a href="https://opencollective.com/typescript-eslint/sponsor/0/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/0/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/1/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/1/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/2/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/2/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/3/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/3/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/4/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/4/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/5/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/5/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/6/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/6/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/7/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/7/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/8/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/8/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/9/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/9/avatar.svg"></a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think contributors & sponsors information belongs in our CONTRIBUTING.md. We already showcase contributors on the root README.md and sponsors on the website. Let's keep each page as small as possible.

Suggested change
## Financial contributions
We also welcome financial contributions in full transparency on our [open collective](https://opencollective.com/typescript-eslint).
Anyone can file an expense. If the expense makes sense for the development of the community, it will be "merged" in the ledger of our open collective by the core contributors and the person who filed the expense will be reimbursed.
### Contributors
Thank you to all the people who have already contributed to typescript-eslint!
<a href="https://github.com/typescript-eslint/typescript-eslint/graphs/contributors"><img src="https://opencollective.com/typescript-eslint/contributors.svg?width=890" /></a>
### Backers
Thank you to all our backers! [[Become a backer](https://opencollective.com/typescript-eslint#backer)]
<a href="https://opencollective.com/typescript-eslint#backers" target="_blank"><img src="https://opencollective.com/typescript-eslint/backers.svg?width=890"></a>
### Sponsors
Thank you to all our sponsors! (please ask your company to also support this open source project by [becoming a sponsor](https://opencollective.com/typescript-eslint#sponsor))
<a href="https://opencollective.com/typescript-eslint/sponsor/0/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/0/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/1/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/1/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/2/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/2/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/3/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/3/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/4/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/4/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/5/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/5/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/6/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/6/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/7/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/7/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/8/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/8/avatar.svg"></a>
<a href="https://opencollective.com/typescript-eslint/sponsor/9/website" target="_blank"><img src="https://opencollective.com/typescript-eslint/sponsor/9/avatar.svg"></a>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

CONTRIBUTING.md Outdated

Please provide **_as much information as possible_**. This project is maintained by volunteers, so the more information you provide, the less likely we will have to waste everyone's time in asking you for more information.

If you have a particularly complex issue - consider creating a small, self-contained reproduction repo. This will help you in figuring out the exact problem, and will help us in reproducing and diagnosing the bug.
If you have a particularly complex issue - consider creating a small, self-contained reproduction repo or use our [playground](https://typescript-eslint.io/play). This will help you in figuring out the exact problem, and will help us in reproducing and diagnosing the bug.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The complex issue template is meant for things that can't be demonstrated on the playground. +1 to mentioning it though. How does this strike you?

Suggested change
If you have a particularly complex issue - consider creating a small, self-contained reproduction repo or use our [playground](https://typescript-eslint.io/play). This will help you in figuring out the exact problem, and will help us in reproducing and diagnosing the bug.
If you have a particularly complex issue that can't be reproduced on [our playground](https://typescript-eslint.io/play) - consider creating a small, self-contained reproduction repo or use. This will help you in figuring out the exact problem, and will help us in reproducing and diagnosing the bug.

CONTRIBUTING.md Outdated
Questions and requests for support should not be opened as issues and should be handled in the following ways:

- Ask a question on [StackOverflow](https://stackoverflow.com/questions/tagged/typescript-eslint) using the `typescript-eslint` tag.
- Join our [Discord server](https://discord.com/invite/??).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, we don't have one. We're not paid enough to deal with a flood of realtime questions from the public. 😄

Pending what the other maintainers think, I'm up for directing people to ask on Twitter instead. I'm pretty active there.

Suggested change
- Join our [Discord server](https://discord.com/invite/??).
- Publicly tweet [@tseslint on Twitter](https://twitter.com/tseslint).

CONTRIBUTING.md Outdated
@@ -70,20 +77,40 @@ We have a sophisticated CI process setup which gets run on every PR. You must pa
Once your changes are ready, you can raise a PR. The title of your PR should match the following format:

```text
<tag>(<package>): <short description>
<type>(<package>): <Subject> (#Issue Number)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The (#Issue Number) gets added by GitHub. We don't need it.

Also, I kind of like short description more than Subject TBH. It's more clear what it's supposed to be: short, not a whole long ordeal. Thoughts?

CONTRIBUTING.md Outdated
<type>(<package>): <Subject> (#Issue Number)
```

Samples: (even more [samples](https://github.com/typescript-eslint/typescript-eslint/commits/main))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking to the latest commits is a good idea. But this sentence is a little oddly worded. Maybe...

Suggested change
Samples: (even more [samples](https://github.com/typescript-eslint/typescript-eslint/commits/main))
You can find more samples of good past PR titles in [recent commits to `main`](https://github.com/typescript-eslint/typescript-eslint/commits/main))

Related: it's an accessibility necessity to have informative link titles. When screenreader folks navigate through the page by skipping through links, they don't receive context around the links. Titles like "samples" don't make much sense out of context.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 4, 2022
@JoshuaKGoldberg JoshuaKGoldberg changed the title docs: Audit and streamline CONTRIBUTING.md (#5120) docs: Audit and streamline CONTRIBUTING.md Sep 4, 2022
@santoshyadavdev
Copy link
Contributor Author

Thanks for reviewing @JoshuaKGoldberg please check now.

@JoshuaKGoldberg
Copy link
Member

🙌 will do!

Btw, you don't need to force push (#5170) or tag me, we have a queue that I go through whenever I can. 🙂

@JoshuaKGoldberg JoshuaKGoldberg removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 5, 2022
@santoshyadavdev
Copy link
Contributor Author

Ahh sorry for that 😅 will keep this in mind.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here, lost track from just having the one note. Thanks for sending this in @santoshyadavdev! Looks great! ❤️

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3b8bca6 into typescript-eslint:main Oct 2, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Audit and streamline CONTRIBUTING.md
2 participants