Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-optional-chain] fix ThisExpression and PrivateIdentifier errors #6028

Merged
merged 25 commits into from Jan 31, 2023
Merged

fix(eslint-plugin): [prefer-optional-chain] fix ThisExpression and PrivateIdentifier errors #6028

merged 25 commits into from Jan 31, 2023

Commits on Nov 17, 2022

  1. prevent thrown error from default case

    Omri Luzon committed Nov 17, 2022
    Copy the full SHA
    71cb502 View commit details
    Browse the repository at this point in the history

  2. try

    Omri Luzon committed Nov 17, 2022
    Copy the full SHA
    5acc1af View commit details
    Browse the repository at this point in the history

  3. Revert "try" 

    This reverts commit 5acc1af.
    Omri Luzon committed Nov 17, 2022
    Copy the full SHA
    a3b6eda View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. More cases and format

    Omri Luzon committed Nov 18, 2022
    Copy the full SHA
    a68b13a View commit details
    Browse the repository at this point in the history

  2. Update packages/eslint-plugin/tests/rules/prefer-optional-chain.test.ts 

    Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
    @omril1 @Josh-Cena
    omril1 and Josh-Cena committed Nov 18, 2022
    Copy the full SHA
    7e2185e View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. Merge remote-tracking branch 'upstream/main' into fix/issue6024-fix-p… 

    …refer-optional-chain-private-and-this-in-negated-or
    Omri Luzon committed Nov 24, 2022
    Copy the full SHA
    1a30e94 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. TSAsExpression,AwaitExpression,NewExpression

    Omri Luzon committed Nov 25, 2022
    Copy the full SHA
    21cfbd2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into fix/issue6024-fix-p… 

    …refer-optional-chain-private-and-this-in-negated-or
    Omri Luzon committed Nov 25, 2022
    Copy the full SHA
    0ae6c45 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Dec 5, 2022
    Copy the full SHA
    ecfacff View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Dec 17, 2022
    Copy the full SHA
    3ce9b0a View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. CR: remove throws and simplify switch cases

    Omri Luzon committed Dec 21, 2022
    Copy the full SHA
    c3c458e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Dec 21, 2022
    Copy the full SHA
    9c15f28 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2022

  1. support private identifiers

    Omri Luzon committed Dec 24, 2022
    Copy the full SHA
    ab70949 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into fix/issue6024-fix-p… 

    …refer-optional-chain-private-and-this-in-negated-or
    Omri Luzon committed Dec 24, 2022
    Copy the full SHA
    e58dab9 View commit details
    Browse the repository at this point in the history

  3. coverage

    Omri Luzon committed Dec 24, 2022
    Copy the full SHA
    12effef View commit details
    Browse the repository at this point in the history

  4. over covered case

    Omri Luzon committed Dec 24, 2022
    Copy the full SHA
    0afc516 View commit details
    Browse the repository at this point in the history

  5. Clearly, we had some missing coverage 😄

    Omri Luzon committed Dec 24, 2022
    Copy the full SHA
    8efa51d View commit details
    Browse the repository at this point in the history

  6. this got uglier

    Omri Luzon committed Dec 24, 2022
    Copy the full SHA
    57b86c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2022

  1. fix coverage

    Omri Luzon committed Dec 25, 2022
    Copy the full SHA
    99528f0 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2023

  1. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Jan 1, 2023
    Copy the full SHA
    cbb5168 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Jan 2, 2023
    Copy the full SHA
    b6d265c View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Jan 13, 2023
    Copy the full SHA
    54d4664 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Merge remote-tracking branch 'upstream/main' into fix/issue6024-fix-p… 

    …refer-optional-chain-private-and-this-in-negated-or

# Conflicts:
#	packages/eslint-plugin/src/rules/prefer-optional-chain.ts
#	packages/eslint-plugin/tests/rules/prefer-optional-chain/prefer-optional-chain.test.ts
    Omri Luzon committed Jan 30, 2023
    Copy the full SHA
    ac8b6a2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Jan 30, 2023
    Copy the full SHA
    a2a6314 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Merge branch 'main' into fix/issue6024-fix-prefer-optional-chain-priv… 

    …ate-and-this-in-negated-or
    Omri Luzon committed Jan 31, 2023
    Copy the full SHA
    37716b2 View commit details
    Browse the repository at this point in the history