Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): add key-spacing rule extension for interface & type declarations #6211

Merged
merged 43 commits into from Jan 24, 2023
Merged

feat(eslint-plugin): add key-spacing rule extension for interface & type declarations #6211

merged 43 commits into from Jan 24, 2023

Commits on Dec 14, 2022

  1. 🚧 key-spacing for interface on default settings

    @coyotte508
    coyotte508 committed Dec 14, 2022
    Copy the full SHA
    eb02b4d View commit details
    Browse the repository at this point in the history

  2. 🚧 Support type literals as welll

    @coyotte508
    coyotte508 committed Dec 14, 2022
    Copy the full SHA
    6d78fe8 View commit details
    Browse the repository at this point in the history

  3. 🚧 Add full typing for the options

    @coyotte508
    coyotte508 committed Dec 14, 2022
    Copy the full SHA
    259a3ca View commit details
    Browse the repository at this point in the history

  4. 🚧 Add 'mode' param

    @coyotte508
    coyotte508 committed Dec 14, 2022
    Copy the full SHA
    8f32b5d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. 🐛 Fix index signatures

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    34bb6d8 View commit details
    Browse the repository at this point in the history

  2. ✨ Support classes

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    ecaafa7 View commit details
    Browse the repository at this point in the history

  3. 🩹 fixes

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    b17665b View commit details
    Browse the repository at this point in the history

  4. ✅ Add tests on mode, multiLine, singleLine

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    18bb8ab View commit details
    Browse the repository at this point in the history

  5. 🏷️ Allow options.multiline.align to be an object

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    4113478 View commit details
    Browse the repository at this point in the history

  6. 🎨 Use ast utils to locate last character before token

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    5e951ba View commit details
    Browse the repository at this point in the history

  7. ✨ Support comments in-between properties

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    b12c530 View commit details
    Browse the repository at this point in the history

  8. ✅ Add test cases for nested type declarations & multiline type annota… 

    …tions
    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    729e642 View commit details
    Browse the repository at this point in the history

  9. ✨ Autofix for non-aligned values

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    d93c1a7 View commit details
    Browse the repository at this point in the history

  10. ✨ Autofix for aligned values

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    ee519e3 View commit details
    Browse the repository at this point in the history

  11. ✏️

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    bc3b5d2 View commit details
    Browse the repository at this point in the history

  12. 🚨

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    eebb18f View commit details
    Browse the repository at this point in the history

  13. 🐛 Support optional ? token

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    179aca2 View commit details
    Browse the repository at this point in the history

  14. ✅ Add tests with class property assignments

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    db2d1bd View commit details
    Browse the repository at this point in the history

  15. 📝 Add documentation on key-spacing

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    dbe502d View commit details
    Browse the repository at this point in the history

  16. 🎨 Use .at() to access last element of array

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    8d5d3dd View commit details
    Browse the repository at this point in the history

  17. ✅ Fix tests

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    af0a489 View commit details
    Browse the repository at this point in the history

  18. fixup! ✅ Fix tests

    @coyotte508
    coyotte508 committed Dec 15, 2022
    Copy the full SHA
    c18b929 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. ✅ Add some coverage

    @coyotte508
    coyotte508 committed Dec 16, 2022
    Copy the full SHA
    37eecdc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into key-spacing

    @coyotte508
    coyotte508 committed Dec 16, 2022
    Copy the full SHA
    75ac325 View commit details
    Browse the repository at this point in the history

  3. 🐛 Fix edge case in determining aligned groups 

    In case there is three statements in one line, and one statement in the line after
    @coyotte508
    coyotte508 committed Dec 16, 2022
    Copy the full SHA
    1b62445 View commit details
    Browse the repository at this point in the history

  4. ⚡️ Use Array.concat instead of .push(...) 

    .push could error if 60k + arguments
    @coyotte508
    coyotte508 committed Dec 16, 2022
    Copy the full SHA
    4b0759c View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. 🎨 Improve readability

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    6d61144 View commit details
    Browse the repository at this point in the history

  2. 🎨 Use tempate literals in tests

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    47156ec View commit details
    Browse the repository at this point in the history

  3. ✅ Add test with anonymous types

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    ae33b9b View commit details
    Browse the repository at this point in the history

  4. ✅ Add test with quoted keys

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    722e092 View commit details
    Browse the repository at this point in the history

  5. ➕ Add grapheme-splitter to deal with emojis

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    301731b View commit details
    Browse the repository at this point in the history

  6. ✅ Add test case for multiline comments

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    9eaebb2 View commit details
    Browse the repository at this point in the history

  7. 🚨 Remove 'in' statements, reduce amount of null-assertions

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    ee6d9bc View commit details
    Browse the repository at this point in the history

  8. ✅ Add test case for properties without type annotation or assignments

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    dbc6a91 View commit details
    Browse the repository at this point in the history

  9. ✅ Add wacky test cases

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    b1033ef View commit details
    Browse the repository at this point in the history

  10. ✅ Add coverage

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    a7a5b2c View commit details
    Browse the repository at this point in the history

  11. ✅ Add coverage, again

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    cb5876e View commit details
    Browse the repository at this point in the history

  12. ✅ Add coverage, again

    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    2787762 View commit details
    Browse the repository at this point in the history

  13. ✅ Add coverage when align is an object, but align.on is missing 

    It defaults to 'colon' in this case
    @coyotte508
    coyotte508 committed Jan 24, 2023
    Copy the full SHA
    79d8ec0 View commit details
    Browse the repository at this point in the history

  14. KeyTypeNodeWithTypeAnnotation

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jan 24, 2023
    Copy the full SHA
    2092487 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'main' into key-spacing

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jan 24, 2023
    Copy the full SHA
    23036de View commit details
    Browse the repository at this point in the history

  16. Merge branch 'main' into key-spacing

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jan 24, 2023
    Copy the full SHA
    e483407 View commit details
    Browse the repository at this point in the history

  17. Extract to shared helper

    @JoshuaKGoldberg
    JoshuaKGoldberg committed Jan 24, 2023
    Copy the full SHA
    0184de9 View commit details
    Browse the repository at this point in the history