Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ast-spec): change MemberExpression.object to Expression #6241

Conversation

JoshuaKGoldberg
Copy link
Member

BREAKING CHANGE:
Switches the AST type for MemberExpression's object property

PR Checklist

Overview

Switches the AST type for MemberExpression's object property from LeftHandSideExpression to Expression.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2022

@netlify
Copy link

netlify bot commented Dec 17, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 643f2cb
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/639e5059b480290008a810f8
😎 Deploy Preview https://deploy-preview-6241--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v6 December 17, 2022 23:27
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Dec 17, 2022
@JoshuaKGoldberg
Copy link
Member Author

Closing in lieu of #6257.

@JoshuaKGoldberg JoshuaKGoldberg deleted the ast-member-expression-object-expression branch December 21, 2022 15:56
@JoshuaKGoldberg JoshuaKGoldberg removed this from the 6.0.0 milestone Dec 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MemberExpression.object should be Expression, not LeftHandSideExpression
1 participant