fix(eslint-plugin)!: [explicit-member-accessibility] Stop checking parameter properties

[ankeetmaini]

BREAKING CHANGE: changes rule config

Fixes #617
Fixes #857

[ankeetmaini]

I am not sure why coverage went down. I added the test cited in the issue and worked my way of figuring out the solution. I am not sure if my approach is correct. Do let me know! Thanks :)

[bradzacher]

unless I'm mistaken, a parameter property is always considered valid under this rule because it always MUST have an accessibility modifier, or else it's not a parameter property?

In that case can't you can just remove the TSParameterProperty selector from the rule altogether, because there's no situation that this rule should check them?

[ankeetmaini]

@bradzacher thanks, I didn't know about it! I've removed the selector, edited some failing tests and rebased the PR with master.

[bradzacher]

one last change - remove the parameterProperties option from the interface and the json schema

[ankeetmaini]

Done!

[ankeetmaini]

I've to update the doc as well. Will do that and update here shortly.

[ark120202]

Parameter properties also can be declared with a readonly modifier:

class Foo {
  constructor(readonly bar: string) {}
}

So the change there should be:

-if (paramPropCheck === 'no-public' && node.accessibility === 'public') {
+if (paramPropCheck === 'no-public' && node.accessibility === 'public' && !node.readonly) {

It also currently doesn't enforce it with explicit, but that's a different issue.

[JamesHenry]

@ankeetmaini we are currently preparing the v2 release (i.e. breaking changes are currently eligible to be merged) when do you think you will have chance to make the change suggested by @ark120202?

[JamesHenry]

See previous comment

[ankeetmaini]

I totally missed the above comment, apologies. So for the above mentioned change, I'll have to undo the removal of parameterProperties , correct? Just confirming.

[bradzacher]

yes, I was wrong, sorry.
I completely forgot about the readonly only case.

Unless I'm mistaken - these should be the states:

valid when parameterProperties: 'off':

• private/protected/public foo
• private/protected/public readonly foo
• readonly foo

valid when parameterProperties: 'explicit':

• private/protected/public foo
• private/protected/public readonly foo
  invalid:
• readonly foo

valid when parameterProperties: 'no-public':

• private/protected/public foo
• private/protected readonly foo
• readonly foo
  invalid:
• public readonly foo

[ankeetmaini]

Closing this in favour of #912