Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix illegal decorator check #6723

Merged
merged 20 commits into from
Jun 17, 2023
Merged

fix: fix illegal decorator check #6723

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
282e115
Fix illegal decorator check
fisker Mar 21, 2023
35304da
Fix
fisker Mar 21, 2023
07b03ee
Fix scope-manager tests
fisker Mar 21, 2023
1a4b800
Fix member-ordering.test.ts
fisker Mar 21, 2023
a2e2a42
Fix no-unused-vars.test.ts
fisker Mar 21, 2023
63f0c3f
Fix explicit-member-accessibility.test.ts
fisker Mar 21, 2023
01c197f
Fix member-ordering-alphabetically-order.test.ts
fisker Mar 21, 2023
af3a56f
Linting
fisker Mar 21, 2023
6360076
Don't check setter getters
fisker Mar 21, 2023
acaee6b
Implement `nodeCanBeDecorated`
fisker Mar 21, 2023
ee03f74
Fix comment
fisker Mar 21, 2023
28a43e7
Fix type
fisker Mar 21, 2023
9a83be1
Revert
fisker Mar 21, 2023
229c4ce
Fix
fisker Mar 21, 2023
aea5e0d
Merge branch 'v6' into decorator-check
fisker Apr 19, 2023
04e3b73
Use `ts.hasAmbientModifier`
fisker Apr 19, 2023
a84fa78
Revert "Use `ts.hasAmbientModifier`"
fisker Apr 19, 2023
1bbf432
refactor: use `getModifiers` and `getDecorators`
fisker Apr 19, 2023
00e9b42
Merge branch 'v6' into decorator-check
JoshuaKGoldberg Jun 17, 2023
e7743d4
Remove stub hasAmbientModifier
JoshuaKGoldberg Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion .../declaration/TSEnumDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...declaration/TSEnumDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion ...aration/TSInterfaceDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...ration/TSInterfaceDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion ...aration/TSTypeAliasDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...ration/TSTypeAliasDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion ...eclaration/VariableDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...claration/VariableDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion ...orRecovery/fixtures/_error_/decorator-on-enum-declaration/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...rRecovery/fixtures/_error_/decorator-on-enum-declaration/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion ...ures/errorRecovery/fixtures/_error_/decorator-on-function/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...res/errorRecovery/fixtures/_error_/decorator-on-function/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion ...overy/fixtures/_error_/decorator-on-interface-declaration/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...very/fixtures/_error_/decorator-on-interface-declaration/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 9 additions & 1 deletion ...ures/errorRecovery/fixtures/_error_/decorator-on-variable/snapshots/1-TSESTree-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...res/errorRecovery/fixtures/_error_/decorator-on-variable/snapshots/3-Alignment-Error.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 0 additions & 8 deletions packages/ast-spec/tests/fixtures-with-differences-errors.shot
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 19 additions & 19 deletions packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1884,7 +1884,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -1910,7 +1910,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -1931,7 +1931,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -1952,7 +1952,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand Down Expand Up @@ -1980,7 +1980,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2001,7 +2001,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2022,7 +2022,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand Down Expand Up @@ -2050,7 +2050,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2071,7 +2071,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2092,7 +2092,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand Down Expand Up @@ -2120,7 +2120,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2141,7 +2141,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2162,7 +2162,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand Down Expand Up @@ -2190,7 +2190,7 @@ class DecoratedClass {
public get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2211,7 +2211,7 @@ class DecoratedClass {
private get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2232,7 +2232,7 @@ class DecoratedClass {
protected get y() {
return this.x;
}
@foo @bar() set y(@foo @bar() value: x) {
@foo @bar() set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand Down Expand Up @@ -2260,7 +2260,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() public set y(@foo @bar() value: x) {
@foo @bar() public set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2281,7 +2281,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() private set y(@foo @bar() value: x) {
@foo @bar() private set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand All @@ -2302,7 +2302,7 @@ class DecoratedClass {
get y() {
return this.x;
}
@foo @bar() protected set y(@foo @bar() value: x) {
@foo @bar() protected set z(@foo @bar() value: x) {
this.x = x;
}
}
Expand Down
6 changes: 3 additions & 3 deletions packages/eslint-plugin/tests/rules/member-ordering.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1454,7 +1454,7 @@ class Foo {
code: `
class Foo {
constructor() {}
@Dec() public A(): void;
@Dec() public A(): void {}
@Dec() private B: string;
private C(): void;
private D: string;
Expand All @@ -1473,7 +1473,7 @@ class Foo {
{
code: `
class Foo {
@Dec() private A(): void;
@Dec() private A(): void {}
@Dec() private B: string;
constructor() {}
private C(): void;
Expand Down Expand Up @@ -1510,7 +1510,7 @@ class Foo {
code: `
class Foo {
public A(): string;
@Dec() public B(): string;
@Dec() public B(): string {}
public C(): string;

d: string;
Expand Down
2 changes: 1 addition & 1 deletion ...es/eslint-plugin/tests/rules/member-ordering/member-ordering-alphabetically-order.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,7 @@ class Foo {
b2: string;

public c(): void;
@Dec() d(): void;
@Dec() d(): void {}
}
`,
options: [
Expand Down
6 changes: 4 additions & 2 deletions packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,8 +778,10 @@ export interface Event<T> {
},
// https://github.com/typescript-eslint/typescript-eslint/issues/2369
`
export default function (@Optional() value = []) {
return value;
export class Test {
constructor(@Optional() value: number[] = []) {
console.log(value);
}
}

function Optional() {
Expand Down
2 changes: 1 addition & 1 deletion packages/scope-manager/tests/eslint-scope/references.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ describe('References:', () => {

declare class C {
@deco
foo(): TypeC;
foo(): TypeC {};
}
`,
{
Expand Down
2 changes: 1 addition & 1 deletion packages/scope-manager/tests/fixtures/decorators/accessor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ class Foo {
return 1;
}
@decorator
set foo() {}
set bar(value) {}
}