Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-useless-constructor] handle bodyless constructor #685

Merged
merged 3 commits into from Jul 25, 2019
Merged

fix(eslint-plugin): [no-useless-constructor] handle bodyless constructor #685

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25b988b
fix(eslint-plugin): [no-useless-constructor] handle bodyless constructor
bradzacher Jul 9, 2019
34d1a30
Merge branch 'master' into fix-no-useless-constructor
bradzacher Jul 12, 2019
18459ef
Merge branch 'master' into fix-no-useless-constructor
JamesHenry Jul 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eslint-plugin/src/rules/no-useless-constructor.ts
View file
Open in desktop
Expand Up @@ -63,6 +63,7 @@ export default util.createRule<Options, MessageIds>({
if (
node.value &&
node.value.type === AST_NODE_TYPES.FunctionExpression &&
node.value.body &&
checkAccessibility(node) &&
checkParams(node)
) {
Expand Down
2 changes: 2 additions & 0 deletions packages/eslint-plugin/tests/rules/no-useless-constructor.test.ts
View file
Open in desktop
Expand Up @@ -50,6 +50,8 @@ ruleTester.run('no-useless-constructor', rule, {
'class A extends B { private constructor(foo, bar) { super(bar); } }',
'class A extends B { public constructor(foo){ super(foo); } }',
'class A extends B { public constructor(foo){} }',
// type definition / overload
'class A { constructor(foo); }',
],
invalid: [
{
Expand Down