typescript-eslint · JamesHenry · Aug 13, 2019 · Jul 20, 2019 · Jul 21, 2019 · Jul 21, 2019
diff --git a/packages/eslint-plugin/README.md b/packages/eslint-plugin/README.md
diff --git a/packages/eslint-plugin/src/configs/base.json b/packages/eslint-plugin/src/configs/base.json
@@ -3,7 +3,5 @@
   "parserOptions": {
     "sourceType": "module"
   },
-  "plugins": [
-    "@typescript-eslint"
-  ]
+  "plugins": ["@typescript-eslint"]
 }
diff --git a/packages/eslint-plugin/src/configs/recommended.json b/packages/eslint-plugin/src/configs/recommended.json
@@ -2,35 +2,41 @@
   "extends": "./configs/base.json",
   "rules": {
     "@typescript-eslint/adjacent-overload-signatures": "error",
-    "@typescript-eslint/array-type": "error",
+    "@typescript-eslint/await-thenable": "error",
+    "@typescript-eslint/ban-ts-ignore": "error",
     "@typescript-eslint/ban-types": "error",
     "camelcase": "off",
     "@typescript-eslint/camelcase": "error",
     "@typescript-eslint/class-name-casing": "error",
-    "@typescript-eslint/consistent-type-definitions": "error",
     "@typescript-eslint/explicit-function-return-type": "warn",
-    "@typescript-eslint/explicit-member-accessibility": "error",
-    "indent": "off",
-    "@typescript-eslint/indent": "error",
     "@typescript-eslint/interface-name-prefix": "error",
     "@typescript-eslint/member-delimiter-style": "error",
     "@typescript-eslint/no-angle-bracket-type-assertion": "error",
     "no-array-constructor": "off",
     "@typescript-eslint/no-array-constructor": "error",
+    "@typescript-eslint/no-empty-function": "error",
     "@typescript-eslint/no-empty-interface": "error",
     "@typescript-eslint/no-explicit-any": "warn",
+    "@typescript-eslint/no-for-in-array": "error",
     "@typescript-eslint/no-inferrable-types": "error",
     "@typescript-eslint/no-misused-new": "error",
+    "@typescript-eslint/no-misused-promises": "error",
     "@typescript-eslint/no-namespace": "error",
-    "@typescript-eslint/no-non-null-assertion": "error",
+    "@typescript-eslint/no-non-null-assertion": "warn",
     "@typescript-eslint/no-object-literal-type-assertion": "error",
-    "@typescript-eslint/no-parameter-properties": "error",
+    "@typescript-eslint/no-this-alias": "error",
+    "@typescript-eslint/no-unnecessary-type-assertion": "error",
     "no-unused-vars": "off",
     "@typescript-eslint/no-unused-vars": "warn",
     "no-use-before-define": "off",
     "@typescript-eslint/no-use-before-define": "error",
     "@typescript-eslint/no-var-requires": "error",
+    "@typescript-eslint/prefer-includes": "error",
     "@typescript-eslint/prefer-namespace-keyword": "error",
-    "@typescript-eslint/type-annotation-spacing": "error"
+    "@typescript-eslint/prefer-regexp-exec": "error",
+    "@typescript-eslint/prefer-string-starts-ends-with": "error",
+    "@typescript-eslint/require-await": "error",
+    "@typescript-eslint/triple-slash-reference": "error",
+    "@typescript-eslint/unbound-method": "error"
   }
 }
diff --git a/packages/eslint-plugin/src/rules/array-type.ts b/packages/eslint-plugin/src/rules/array-type.ts
@@ -86,7 +86,8 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Requires using either `T[]` or `Array<T>` for arrays',
       category: 'Stylistic Issues',
-      recommended: 'error',
+      // too opinionated to be recommended
+      recommended: false,
     },
     fixable: 'code',
     messages: {

diff --git a/packages/eslint-plugin/src/rules/await-thenable.ts b/packages/eslint-plugin/src/rules/await-thenable.ts
@@ -9,7 +9,7 @@ export default util.createRule({
     docs: {
       description: 'Disallows awaiting a value that is not a Thenable',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       await: 'Unexpected `await` of a non-Promise (non-"Thenable") value.',

diff --git a/packages/eslint-plugin/src/rules/ban-ts-ignore.ts b/packages/eslint-plugin/src/rules/ban-ts-ignore.ts
@@ -7,7 +7,7 @@ export default util.createRule({
     docs: {
       description: 'Bans “// @ts-ignore” comments from being used',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     schema: [],
     messages: {

diff --git a/packages/eslint-plugin/src/rules/consistent-type-definitions.ts b/packages/eslint-plugin/src/rules/consistent-type-definitions.ts
@@ -9,6 +9,7 @@ export default util.createRule({
       description:
         'Consistent with type definition either `interface` or `type`',
       category: 'Stylistic Issues',
+      // too opinionated to be recommended
       recommended: false,
     },
     messages: {

diff --git a/packages/eslint-plugin/src/rules/explicit-function-return-type.ts b/packages/eslint-plugin/src/rules/explicit-function-return-type.ts
@@ -47,8 +47,8 @@ export default util.createRule<Options, MessageIds>({
   defaultOptions: [
     {
       allowExpressions: false,
-      allowTypedFunctionExpressions: false,
-      allowHigherOrderFunctions: false,
+      allowTypedFunctionExpressions: true,
+      allowHigherOrderFunctions: true,
     },
   ],
   create(context, [options]) {

diff --git a/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts b/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts
@@ -33,8 +33,9 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description:
         'Require explicit accessibility modifiers on class properties and methods',
-      category: 'Best Practices',
-      recommended: 'error',
+      category: 'Stylistic Issues',
+      // too opinionated to be recommended
+      recommended: false,
     },
     messages: {
       missingAccessibility:

diff --git a/packages/eslint-plugin/src/rules/generic-type-naming.ts b/packages/eslint-plugin/src/rules/generic-type-naming.ts
@@ -10,6 +10,7 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Enforces naming of generic type variables',
       category: 'Stylistic Issues',
+      // too opinionated to be recommended
       recommended: false,
     },
     messages: {

diff --git a/packages/eslint-plugin/src/rules/indent.ts b/packages/eslint-plugin/src/rules/indent.ts
@@ -89,7 +89,8 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Enforce consistent indentation',
       category: 'Stylistic Issues',
-      recommended: 'error',
+      // too opinionated to be recommended
+      recommended: false,
     },
     fixable: 'whitespace',
     schema: baseRule.meta.schema,

diff --git a/packages/eslint-plugin/src/rules/interface-name-prefix.ts b/packages/eslint-plugin/src/rules/interface-name-prefix.ts
@@ -10,6 +10,8 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Require that interface names be prefixed with `I`',
       category: 'Stylistic Issues',
+      // this will always be recommended as there's no reason to use this convention
+      // https://github.com/typescript-eslint/typescript-eslint/issues/374
       recommended: 'error',
     },
     messages: {

diff --git a/packages/eslint-plugin/src/rules/no-empty-function.ts b/packages/eslint-plugin/src/rules/no-empty-function.ts
@@ -15,7 +15,7 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Disallow empty functions',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     schema: baseRule.meta.schema,
     messages: baseRule.meta.messages,

diff --git a/packages/eslint-plugin/src/rules/no-for-in-array.ts b/packages/eslint-plugin/src/rules/no-for-in-array.ts
@@ -7,7 +7,7 @@ export default util.createRule({
     docs: {
       description: 'Disallow iterating over an array with a for-in loop',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       forInViolation:

diff --git a/packages/eslint-plugin/src/rules/no-misused-new.ts b/packages/eslint-plugin/src/rules/no-misused-new.ts
@@ -16,7 +16,7 @@ export default util.createRule({
     schema: [],
     messages: {
       errorMessageInterface: 'Interfaces cannot be constructed, only classes.',
-      errorMessageClass: 'Class cannon have method named `new`.',
+      errorMessageClass: 'Class cannot have method named `new`.',
     },
   },
   defaultOptions: [],

diff --git a/packages/eslint-plugin/src/rules/no-misused-promises.ts b/packages/eslint-plugin/src/rules/no-misused-promises.ts
@@ -17,7 +17,7 @@ export default util.createRule<Options, 'conditional' | 'voidReturn'>({
     docs: {
       description: 'Avoid using promises in places not designed to handle them',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       voidReturn:

diff --git a/packages/eslint-plugin/src/rules/no-non-null-assertion.ts b/packages/eslint-plugin/src/rules/no-non-null-assertion.ts
@@ -8,7 +8,7 @@ export default util.createRule({
       description:
         'Disallows non-null assertions using the `!` postfix operator',
       category: 'Stylistic Issues',
-      recommended: 'error',
+      recommended: 'warn',
     },
     messages: {
       noNonNull: 'Forbidden non-null assertion.',

diff --git a/packages/eslint-plugin/src/rules/no-parameter-properties.ts b/packages/eslint-plugin/src/rules/no-parameter-properties.ts
@@ -27,7 +27,8 @@ export default util.createRule<Options, MessageIds>({
       description:
         'Disallow the use of parameter properties in class constructors',
       category: 'Stylistic Issues',
-      recommended: 'error',
+      // too opinionated to be recommended
+      recommended: false,
     },
     messages: {
       noParamProp:

diff --git a/packages/eslint-plugin/src/rules/no-this-alias.ts b/packages/eslint-plugin/src/rules/no-this-alias.ts
@@ -19,7 +19,7 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Disallow aliasing `this`',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     schema: [
       {

diff --git a/packages/eslint-plugin/src/rules/no-triple-slash-reference.ts b/packages/eslint-plugin/src/rules/no-triple-slash-reference.ts
@@ -7,7 +7,7 @@ export default util.createRule({
     docs: {
       description: 'Disallow `/// <reference path="" />` comments',
       category: 'Best Practices',
-      recommended: 'error',
+      recommended: false,
     },
     schema: [],
     deprecated: true,

diff --git a/packages/eslint-plugin/src/rules/no-type-alias.ts b/packages/eslint-plugin/src/rules/no-type-alias.ts
@@ -44,6 +44,7 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Disallow the use of type aliases',
       category: 'Stylistic Issues',
+      // too opinionated to be recommended
       recommended: false,
     },
     messages: {

diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts b/packages/eslint-plugin/src/rules/no-unnecessary-type-assertion.ts
@@ -27,7 +27,7 @@ export default util.createRule<Options, MessageIds>({
       description:
         'Warns if a type assertion does not change the type of an expression',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     fixable: 'code',
     messages: {

diff --git a/packages/eslint-plugin/src/rules/prefer-includes.ts b/packages/eslint-plugin/src/rules/prefer-includes.ts
@@ -13,7 +13,7 @@ export default createRule({
     docs: {
       description: 'Enforce `includes` method over `indexOf` method',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     fixable: 'code',
     messages: {

diff --git a/packages/eslint-plugin/src/rules/prefer-interface.ts b/packages/eslint-plugin/src/rules/prefer-interface.ts
@@ -9,7 +9,8 @@ export default util.createRule({
       description:
         'Prefer an interface declaration over a type literal (type T = { ... })',
       category: 'Stylistic Issues',
-      recommended: 'error',
+      // too opinionated to be recommended
+      recommended: false,
     },
     fixable: 'code',
     messages: {

diff --git a/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts b/packages/eslint-plugin/src/rules/prefer-regexp-exec.ts
@@ -12,7 +12,7 @@ export default createRule({
       description:
         'Prefer RegExp#exec() over String#match() if no global flag is provided',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       regExpExecOverStringMatch: 'Use the `RegExp#exec()` method instead.',

diff --git a/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts b/packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts
@@ -20,7 +20,7 @@ export default createRule({
       description:
         'Enforce the use of `String#startsWith` and `String#endsWith` instead of other equivalent methods of checking substrings',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       preferStartsWith: "Use 'String#startsWith' method instead.",

diff --git a/packages/eslint-plugin/src/rules/require-await.ts b/packages/eslint-plugin/src/rules/require-await.ts
@@ -23,7 +23,7 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Disallow async functions which have no `await` expression',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     schema: baseRule.meta.schema,
     messages: baseRule.meta.messages,

diff --git a/packages/eslint-plugin/src/rules/semi.ts b/packages/eslint-plugin/src/rules/semi.ts
@@ -16,6 +16,7 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Require or disallow semicolons instead of ASI',
       category: 'Stylistic Issues',
+      // too opinionated to be recommended
       recommended: false,
     },
     fixable: 'code',

diff --git a/packages/eslint-plugin/src/rules/triple-slash-reference.ts b/packages/eslint-plugin/src/rules/triple-slash-reference.ts
@@ -18,7 +18,7 @@ export default util.createRule<Options, MessageIds>({
       description:
         'Sets preference level for triple slash directives versus ES6-style import declarations',
       category: 'Best Practices',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       tripleSlashReference:

diff --git a/packages/eslint-plugin/src/rules/type-annotation-spacing.ts b/packages/eslint-plugin/src/rules/type-annotation-spacing.ts
@@ -39,7 +39,8 @@ export default util.createRule<Options, MessageIds>({
     docs: {
       description: 'Require consistent spacing around type annotations',
       category: 'Stylistic Issues',
-      recommended: 'error',
+      // too opinionated to be recommended
+      recommended: false,
     },
     fixable: 'whitespace',
     messages: {

diff --git a/packages/eslint-plugin/src/rules/unbound-method.ts b/packages/eslint-plugin/src/rules/unbound-method.ts
@@ -25,7 +25,7 @@ export default util.createRule<Options, MessageIds>({
       category: 'Best Practices',
       description:
         'Enforces unbound methods are called with their expected scope',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       unbound:

diff --git a/packages/eslint-plugin/src/rules/unified-signatures.ts b/packages/eslint-plugin/src/rules/unified-signatures.ts
@@ -55,6 +55,7 @@ export default util.createRule({
       description:
         'Warns for any two overloads that could be unified into one by using a union or an optional/rest parameter',
       category: 'Variables',
+      // too opinionated to be recommended
       recommended: false,
     },
     type: 'suggestion',