Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Babel to Dependency Version Upgrades #7415

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Now that #6065 was merged earlier this year, it seems like this is pretty straightforward? Am I missing anything?

I ran the yarn add -DW @babel/... command as described just to be sure.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit dfa9842
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64fb0c6a5d78db00082ac513
😎 Deploy Preview https://deploy-preview-7415--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud
Copy link

nx-cloud bot commented Aug 5, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dfa9842. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx build website
✅ Successfully ran 39 targets

Sent with 💌 from NxCloud.

bradzacher
bradzacher previously approved these changes Sep 7, 2023
@bradzacher bradzacher added documentation Documentation ("docs") that needs adding/updating 1 approval One team member has approved this PR; a second should be enough to merge it labels Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #7415 (dfa9842) into main (4908905) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7415   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files         387      387           
  Lines       13401    13404    +3     
  Branches     3962     3962           
=======================================
+ Hits        11690    11693    +3     
  Misses       1327     1327           
  Partials      384      384           
Flag Coverage Δ
unittest 87.23% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📢 Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=typescript-eslint).

@JoshuaKGoldberg JoshuaKGoldberg merged commit 1bad832 into typescript-eslint:main Sep 8, 2023
47 of 50 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the babel-bump-docs branch September 8, 2023 12:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval One team member has approved this PR; a second should be enough to merge it documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Maintenance > Bumping the Babel version
2 participants