New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(eslint-plugin): add Deprecating Formatting Rules blog post #8117
docs(eslint-plugin): add Deprecating Formatting Rules blog post #8117
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks great; not sure if the code change should be a separate PR but no strong feelings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice post!
I just found a few typos
By the way, maybe this has already been discussed somewhere, but I missed it:
What about no-extra-semi
rule? It's classified as suggestion
rather than layout
, but it's already a part of eslint-stylistic
Shouldn't we deprecate it as well? Because otherwise it will be duplicated in both ts-eslint
and eslint-stylistic
packages/website/blog/2023-12-25-deprecating-formatting-rules.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2023-12-25-deprecating-formatting-rules.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2023-12-25-deprecating-formatting-rules.md
Outdated
Show resolved
Hide resolved
packages/eslint-plugin/src/rules/lines-between-class-members.ts
Outdated
Show resolved
Hide resolved
I asked a while ago privately; I think Brad is in favor of removing it too :) |
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
Heh yeah in theory maybe. But it's all going to ship at the same time. And I think this only impacts documentation anyhow. |
b3f87fc
into
typescript-eslint:main
Thank you! And Merry Christmas to you all! |
…script-eslint#8117) * chore(website): add Deprecating Formatting Rules blog post * Apply suggestions from code review Co-authored-by: auvred <61150013+auvred@users.noreply.github.com> * Update packages/website/blog/2023-12-25-deprecating-formatting-rules.md Co-authored-by: auvred <61150013+auvred@users.noreply.github.com> * Update packages/website/blog/2023-12-25-deprecating-formatting-rules.md Co-authored-by: auvred <61150013+auvred@users.noreply.github.com> * Ran format --write * Add no-extra-semi too * Generalize formatting notice to @stylistic/ rules --------- Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
PR Checklist
Overview
Summarizes why we're doing this and links to the ESLint blog post + ESLint Stylistic docs as well.
Also includes a fix to the rule replacements: I'd forgotten
ts/
exists as a separate namespace fromdefault/
.