Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): add JSDocParsingMode enum merge for typescript/lib/tsserverlibrary #8193

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds in a declare module 'typescript/lib/tsserverlibrary' similar to the existing declare module 'typescript'. This way imports of JSDocParsingMode` from either location will be allowed even if the installed TypeScript version doesn't have the enum.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 5, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 78a6012
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6599fbb6305c4f0008eeced5
😎 Deploy Preview https://deploy-preview-8193--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradzacher bradzacher added the bug Something isn't working label Jan 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit e80d54e into typescript-eslint:main Jan 12, 2024
57 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the jsdoc-parsing-mode-from-tsserverlibrary branch January 12, 2024 00:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: typescript-estree 6.16.0+ requires TypeScript v5.3+
2 participants