Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): parse comments after jsx attribute #847

Closed
wants to merge 1 commit into from
Closed

fix(typescript-estree): parse comments after jsx attribute #847

wants to merge 1 commit into from

Conversation

meowtec
Copy link

@meowtec meowtec commented Aug 13, 2019

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @meowtec!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #847 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
+ Coverage   94.19%   94.19%   +<.01%     
==========================================
  Files         112      112              
  Lines        4825     4826       +1     
  Branches     1338     1339       +1     
==========================================
+ Hits         4545     4546       +1     
  Misses        160      160              
  Partials      120      120
Impacted Files Coverage Δ
packages/typescript-estree/src/convert-comments.ts 96.36% <100%> (+0.06%) ⬆️

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Aug 13, 2019
@bradzacher
Copy link
Member

I don't know much about the parsing infra, but unless I'm mistaken this is covered by #703?

@JamesHenry
Copy link
Member

Yes I think it is and I just merged it :)

@JamesHenry JamesHenry closed this Aug 13, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants