docs(parser): clarify mixed codebase configuration #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People were having some problems because we now throw errors if files aren't included in the tsconfig - which is the case for a lot of users. This just clarifies the documentation so that it covers all the bases.
bradzacher
added
the
documentation
This comment has been minimized.
This comment has been minimized.
bradzacher
added a commit
that referenced
this pull request
Aug 15, 2019
bradzacher
added a commit
that referenced
this pull request
Aug 15, 2019
|
closing in favour of #866 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853
People were having some problems because we now throw errors if files aren't included in the tsconfig.
For mixed js/ts codebases, this is pretty much the default state, as users didn't run typescript on their JS code.
This just clarifies the documentation so that it covers all the bases.
Also moved
createDefaultProgramto the bottom of the list and emphasised that people shouldn't use it.