fix(eslint-plugin): [explicit-member-accessibility] refine report locations

[kirkwaiblinger]

PR Checklist

• Addresses an existing open issue: fixes partially Enhancement: Improve lint error report location #8543
• That issue was marked as accepting prs
• Steps in Contributing were taken

cc @developer-bandi

Overview

This PR makes it so that for missing accessibility modifiers, we report just the symbol name preceeded by however many keywords (get, abstract, etc)

class A {
   // before
   @foo
   ^^^^
   get x(): string {
^^^^^^^^^^^^^^^^^^^^
   }
^^^^
   // after
   @foo
   get x(): string {
   ^^^^^
   }
}

and for public modifiers that should not be present, we only flag on the public keyword itself

class A {
    // before
    public abstract method(x: string): number;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    // after
    public abstract method(x: string): number;
    ^^^^^^
}

[typescript-eslint]

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	602de2a
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66346bc010dc4e0008d40e11
😎 Deploy Preview	https://deploy-preview-8869--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 602de2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test eslint-plugin
• nx test utils --coverage=false
• nx run types:build
• nx test typescript-eslint --coverage=false
• nx test type-utils --coverage=false
• nx run repo-tools:postinstall-script
• nx test visitor-keys --coverage=false
• nx test scope-manager --coverage=false
• nx test typescript-estree --coverage=false
• nx test repo-tools --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test typescript-eslint
• nx test visitor-keys
• nx test type-utils
• nx test utils
• nx test parser --coverage=false
• nx test scope-manager
• nx test typescript-estree
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test rule-schema-to-typescript-types
• nx test repo-tools
• nx test eslint-plugin-internal
• nx test parser
• nx test ast-spec
• nx test ast-spec --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx run-many --target=typecheck --parallel
• nx run integration-tests:test
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[kirkwaiblinger]

changed this since it's illegal syntax for a parameter property to be a rest element. Though the rule doesn't really care.

[kirkwaiblinger]

i audited every invalid test case and put in the exact report range, since it was very helpful for development to do so. I realize, however, that that may be overkill for testing (and can make modifications to the rule or test cases unnecessarily unwieldy). If requested, I can remove some of the added report locations. But IMO they might as well stay now that they're there

[bradzacher]

Eventually we'll have #6994 and we can kill all of the line/col assertions.

[Josh-Cena]

@kirkwaiblinger If you don't want to auto-close that issue, you have to make sure your description doesn't contain the substring "fixes #xxx". You can say "fixes (partially) #xxx" (I usually do that)

[kirkwaiblinger]

Confused by the CI failure, looking for advice on how to resolve it

[bradzacher]