Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ci.yml canary releases to use nx, not lerna #8962

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Apr 21, 2024

PR Checklist

Overview

I'm ... not sure which command we should use here 😬 is it ... nx release?

Partially overlaps #8913.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 21, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5157243
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/662ac2d34da4780008026ab4
😎 Deploy Preview https://deploy-preview-8962--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (9e0d9f5) to head (6a5d9aa).
Report is 10 commits behind head on main.

❗ Current head 6a5d9aa differs from pull request most recent head 5157243. Consider uploading reports for the commit 5157243 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8962      +/-   ##
==========================================
+ Coverage   87.40%   88.05%   +0.64%     
==========================================
  Files         257      407     +150     
  Lines       12525    14103    +1578     
  Branches     3928     4126     +198     
==========================================
+ Hits        10948    12418    +1470     
- Misses       1303     1381      +78     
- Partials      274      304      +30     
Flag Coverage Δ
unittest 88.05% <ø> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 150 files with indirect coverage changes

docs/maintenance/Releases.mdx Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg merged commit 4858afd into typescript-eslint:main Apr 26, 2024
61 of 62 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the lerna-nx-v8-releases branch April 26, 2024 00:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: CI failing to publish v8 canaries
2 participants