Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint peer dependency to "^8.56.0 || ^9.0.0" #9010

Closed
wants to merge 1 commit into from

Conversation

honeymaro
Copy link
Contributor

PR Checklist

Overview

Since eslint v9 is a major version, I added it to peerDependencies to avoid a warning message when installing eslint and typescript-eslint.

yarn classic:

$ yarn add -D typescript-eslint
yarn add v1.22.19
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @typescript-eslint/eslint-plugin@7.7.1" has incorrect peer dependency "eslint@^8.56.0".
warning "@typescript-eslint/eslint-plugin > @typescript-eslint/type-utils@7.7.1" has incorrect peer dependency "eslint@^
8.56.0".
warning "@typescript-eslint/eslint-plugin > @typescript-eslint/utils@7.7.1" has incorrect peer dependency "eslint@^8.56.
0".
warning " > @typescript-eslint/parser@7.7.1" has incorrect peer dependency "eslint@^8.56.0".
[4/4] Building fresh packages...

yarn berry:

$ yarn add -D typescript-eslint
➤ YN0000: · Yarn 4.1.1
➤ YN0000: ┌ Resolution step
➤ YN0085: │ + typescript-eslint@npm:7.7.1, @types/json-schema@npm:7.0.15, @types/semver@npm:7.5.8, and 24 more.
➤ YN0000: └ Completed in 4s 119ms
➤ YN0000: ┌ Post-resolution validation
➤ YN0060: │ eslint is listed by your project with version 9.1.1, which doesn't satisfy what typescript-eslint (p47665) a
nd other dependencies request (^8.56.0).
➤ YN0086: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <ha
sh> is the six-letter p-prefixed code.
➤ YN0000: └ Completed
➤ YN0000: ┌ Fetch step
➤ YN0013: │ 27 packages were added to the project (+ 6.78 MiB).
➤ YN0000: └ Completed in 0s 916ms
➤ YN0000: ┌ Link step
➤ YN0000: │ ESM support for PnP uses the experimental loader API and is therefore experimental
➤ YN0000: └ Completed in 0s 272ms
➤ YN0000: · Done with warnings in 5s 356ms

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @honeymaro!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 01986bf
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/662cb79e579a320007449a92
😎 Deploy Preview https://deploy-preview-9010--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@bradzacher
Copy link
Member

bradzacher commented Apr 27, 2024

We don't currently support eslint v9 - hence the issue you linked. We are working to build out support and will update the version range when it is ready.

#9002

@bradzacher bradzacher closed this Apr 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants