Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): pass extraFileExtensions to projectService #9051

Open
wants to merge 1 commit into
base: v8
Choose a base branch
from

Conversation

alfredringstad
Copy link

PR Checklist

Overview

Uses setHostConfiguration to pass extraFileExtensions to project service, when using EXPERIMENTAL_useProjectService. This fixes an issue where project service would not detect the appropriate tsconfig file when using non-default file extensions.

The tests are checking that the configFilePath is set in the compiler options. If it's not, it's an indication that the default inferred project is used. I duplicated the test cases used for the non-experimental projects option.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @alfredringstad!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a19ab95
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/663b12dbe4e91c0008785534
😎 Deploy Preview https://deploy-preview-9051--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@alfredringstad alfredringstad force-pushed the pass-extraFileExtensions-to-projectService branch 2 times, most recently from 5e3d1c0 to 88c1ab6 Compare May 6, 2024 11:43
@alfredringstad alfredringstad force-pushed the pass-extraFileExtensions-to-projectService branch from 88c1ab6 to c21ca49 Compare May 6, 2024 11:49
@alfredringstad alfredringstad changed the base branch from main to v8 May 8, 2024 05:49
@alfredringstad alfredringstad force-pushed the pass-extraFileExtensions-to-projectService branch from c21ca49 to a19ab95 Compare May 8, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: EXPERIMENTAL_useProjectService does not respect extraFileExtensions
1 participant