Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): apply initial config changes for v8 #9079

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 12, 2024

BREAKING CHANGE:
Adjusts the shared configs.

PR Checklist

Overview

Applies the changes that were suggested in #8914.

Note that this is into the v8 branch, not main. It'll only impact the v8 line of versions. We'll try this out on a set of community repositories to see how it feels.

💖

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone May 12, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 12, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b96700a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6654a871a31173000861e05d
😎 Deploy Preview https://deploy-preview-9079--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented May 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b96700a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=lint --parallel --exclude eslint-plugin
✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 13, 2024 00:19
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team May 13, 2024 00:19
@JoshuaKGoldberg
Copy link
Member Author

CI flake. This passes linting locally.

@JoshuaKGoldberg JoshuaKGoldberg added the breaking change This change will require a new major version to be released label May 27, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit ae1414c into typescript-eslint:v8 May 27, 2024
56 of 60 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the v8-config-changes branch May 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants