feat(rule-tester): stricter rule test validations

[Vinccool96]

PR Checklist

• Addresses an existing open issue: fixes Enhancement(rule-tester): Stricter rule test validations #9016
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Brings in changes from eslint/eslint#17654. This is pretty much a copy & paste.

[typescript-eslint]

Thanks for the PR, @Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	e761ee1
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6661cb7299fe4d0008e7bf2d
😎 Deploy Preview	https://deploy-preview-9086--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (🔴 down 8 from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e761ee1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 31 targets

• nx test eslint-plugin --coverage=false
• nx test type-utils --coverage=false
• nx test eslint-plugin
• nx run types:build
• nx test utils --coverage=false
• nx test typescript-eslint --coverage=false
• nx run repo-tools:postinstall-script
• nx test typescript-estree --coverage=false
• nx test visitor-keys --coverage=false
• nx test scope-manager --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx test repo-tools --coverage=false
• nx test ast-spec --coverage=false
• nx test parser --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx test typescript-estree
• nx test utils
• nx test visitor-keys
• nx test repo-tools
• nx test typescript-eslint
• nx test type-utils
• nx test scope-manager
• nx run integration-tests:test
• nx test parser
• nx test eslint-plugin-internal
• nx test rule-schema-to-typescript-types
• nx test ast-spec
• nx run-many --target=typecheck --parallel
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[Vinccool96]

I'm gonna need some help for the failing tests

Never mind, there was way less things to fix than I thought.

[Vinccool96]

@auvred Is everything good to merge?

[auvred]

Left a few minor requests but overall looks great!

---

Btw, there is no need to ping individuals for review. We have a queue and we get to things when we can. https://typescript-eslint.io/contributing/pull-requests