Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct eslint-plugin's peerDependency on parser@8 #9089

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Corrects the last ^7.0.0 peer dependency that we'd missed.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ce33ea4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66423200002041000880923a
😎 Deploy Preview https://deploy-preview-9089--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team May 13, 2024 15:31
Copy link

nx-cloud bot commented May 13, 2024

Copy link
Member

@auvred auvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@auvred auvred added the 1 approval One team member has approved this PR; a second should be enough to merge it label May 13, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 94bd289 into typescript-eslint:v8 May 13, 2024
60 of 61 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-plugin-peer-dependency branch May 14, 2024 15:33
@JoshuaKGoldberg
Copy link
Member Author

Published in typescript-eslint@8.0.0-alpha.11 🚀

@@ -102,7 +102,7 @@
"unist-util-visit": "^5.0.0"
},
"peerDependencies": {
"@typescript-eslint/parser": "^7.0.0",
"@typescript-eslint/parser": "^8.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that ^ will not match "pre release" ranges by default.
If you add the base, re-release version then semver will match all those pre-release versions

Suggested change
"@typescript-eslint/parser": "^8.0.0",
"@typescript-eslint/parser": "^8.0.0 || ^8.0.0-alpha.0",

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval One team member has approved this PR; a second should be enough to merge it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants