-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct eslint-plugin's peerDependency on parser@8 #9089
fix: correct eslint-plugin's peerDependency on parser@8 #9089
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
Published in |
@@ -102,7 +102,7 @@ | |||
"unist-util-visit": "^5.0.0" | |||
}, | |||
"peerDependencies": { | |||
"@typescript-eslint/parser": "^7.0.0", | |||
"@typescript-eslint/parser": "^8.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that ^
will not match "pre release" ranges by default.
If you add the base, re-release version then semver will match all those pre-release versions
"@typescript-eslint/parser": "^8.0.0", | |
"@typescript-eslint/parser": "^8.0.0 || ^8.0.0-alpha.0", |
PR Checklist
Overview
Corrects the last
^7.0.0
peer dependency that we'd missed.💖