chore: use recommended config for Node.js 18 in TSConfig

[lesha1201]

PR Checklist

• Addresses an existing open issue: fixes Repo: Raise TSConfig lib/target support range to match ESLint's #9028
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Changed TSConfig to target Node.js 18 since this is the minimal version we support. According to https://node.green/, Node.js 18 fully supports ES2022 and ES2023:

There is a recommended TSConfig for Node.js 18 - https://github.com/tsconfig/bases/blob/main/bases/node18.json and I followed it as a reference.

In another PR, I'm planning to enable ESLint https://eslint.org/docs/latest/rules/prefer-object-has-own rule and fix all related errors.

[typescript-eslint]

Thanks for the PR, @lesha1201!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	fbeede9
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6647838c36cdfd0008ffa5c0
😎 Deploy Preview	https://deploy-preview-9113--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[lesha1201]

It extends tsconfig.base.json so no need to specify it anymore.

[lesha1201]

It extends tsconfig.base.json so no need to specify it.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fbeede9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 32 targets

• nx test eslint-plugin --coverage=false
• nx run-many --target=test --parallel --exclude integration-tests --exclude website --exclude website-eslint
• nx test eslint-plugin
• nx test typescript-estree --coverage=false
• nx test utils --coverage=false
• nx test typescript-eslint --coverage=false
• nx test rule-schema-to-typescript-types --coverage=false
• nx run types:build
• nx test visitor-keys --coverage=false
• nx test scope-manager --coverage=false
• nx run repo-tools:postinstall-script
• nx test parser --coverage=false
• nx test type-utils --coverage=false
• nx test ast-spec --coverage=false
• nx test repo-tools --coverage=false
• nx test eslint-plugin-internal --coverage=false
• nx run-many --target=lint --parallel --exclude eslint-plugin
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint
• nx test typescript-estree
• nx test utils
• nx test scope-manager
• nx test type-utils
• nx test ast-spec
• nx test typescript-eslint
• nx test visitor-keys
• nx test eslint-plugin-internal
• nx test rule-schema-to-typescript-types
• nx test parser
• nx test repo-tools
• nx run integration-tests:test
• nx run-many --target=typecheck --parallel
• nx run repo-tools:generate-configs

---

Sent with 💌 from NxCloud.

[auvred]

Note: it looks like #9038 already contains some changes in this area

[jakebailey]

I was going to ask why ES2023 was legal, but node.green does in fact show that all versions of Node 18 support all runtime features of ES2023. I've fixed https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping to reflect this (which matches the bases too).

[JoshuaKGoldberg]

Nice!!

[JoshuaKGoldberg]

Aside: I'm surprised TS 5.4 doesn't support an ES2023 target. I tried that locally and got:

   ✖  nx run ast-spec:build


      ../../tsconfig.base.json(19,15): error TS6046: Argument for '--target' option must be: 'es5', 'es6', 'es2015', 'es2016', 'es2017', 'es2018', 'es2019', 'es2020', 'es2021', 'es2022', 'esnext'.
      Warning: command "yarn build" exited with non-zero status code

microsoft/TypeScript#56303 - turns out es2023 === es2022 for target so it was kept out. Huh.

[jakebailey]

Yes, this was rectified in microsoft/TypeScript#58140 and we plan to not skip again.

[JoshuaKGoldberg]

Super, thanks! 🚀