fix: disable IPC communication until TypeScript bug is fixed #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug The issue with using IPC communication is that if the parent process gets killed the the tsserver process does not shut itself down. This will be re-enabled once the Typescript issue (microsoft/TypeScript#51100) is fixed. Fixes #599
|
Seems to be fixed upstream? microsoft/TypeScript#51107 |
|
I know. I've submitted the fix there :) Now we need to wait for new version of TypeScript that includes the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with using IPC communication for communicating with
tsserveris that if the parent process gets killed then thetsserverprocess does not shut itself down.This will be re-enabled once the Typescript issue (microsoft/TypeScript#51100) is fixed.
Fixes #599