Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/Reduce unnecessary API calls #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/Reduce unnecessary API calls #46

wants to merge 2 commits into from

Conversation

arayiksmbatyan
Copy link
Contributor

@arayiksmbatyan arayiksmbatyan commented Feb 6, 2023 •
edited

Change Summary

PR Checklist

@michgeek
Copy link

I think it's better to revert that change, as in #50 or #47 rather than merging this one.

@manavo
Copy link
Contributor

manavo commented Feb 27, 2023

This could work, but instead of the check for running in console, wouldn't it be better to just do the dirty check for each of the models in the collection? Then filter it down based on that?

@karakhanyans
Merge branch 'master' into bugfix/reduce_unnecessary_api_calls
109b177 
# Conflicts:
#	src/Engines/TypesenseEngine.php
ankit-gautam23
ankit-gautam23 approved these changes Apr 28, 2023
View reviewed changes
Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankit-gautam23 ankit-gautam23 ankit-gautam23 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arayiksmbatyan @michgeek @manavo @ankit-gautam23 @karakhanyans