Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos and reformat decorators table #1849

Merged
merged 1 commit into from
Dec 15, 2022
Merged

docs: fix typos and reformat decorators table #1849

merged 1 commit into from
Dec 15, 2022

Conversation

carlocorradini
Copy link
Contributor

Description

Fixed some readme typo(s) and decorators table formatting

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

@NoNameProvided
Copy link
Member

Hey, thanks for opening this but it won't get merged. Formatting the markdown table is disabled on purpose.

@carlocorradini
Copy link
Contributor Author

Have you seen that date decorators are broken?

@carlocorradini
Copy link
Contributor Author

Can I ask why table formatting is disabled? With prettier formatting the result is well aligned and easily understandable.

@NoNameProvided
Copy link
Member

Have you seen that date decorators are broken?

What do you mean?

@carlocorradini
Copy link
Contributor Author

carlocorradini commented Dec 13, 2022

See the screenshot:
Screenshot_2022-12-13-21-40-38-80_320a9a695de7cdce83ed5281148d6f19.jpg

minDate and maxDate are broken

@NoNameProvided NoNameProvided changed the title docs(readme): fixed some readme typo(s) and decorators table formatting docs: fix typos and reformat decorators table Dec 15, 2022
@NoNameProvided NoNameProvided merged commit 2e360ee into typestack:develop Dec 15, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants