Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update @IsPhoneNumber decorator to use max dataset #1857

Merged

Conversation

NoNameProvided
Copy link
Member

Description

This PR updates the @IsPhoneNumber decorator to use the max dataset for validation and reworks to validator function to use shorter code for validation.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

fixes none

@NoNameProvided NoNameProvided force-pushed the feat/update-is-phone-number-to-validate-better branch 2 times, most recently from 32c8231 to 9876eea Compare December 15, 2022 21:07
@NoNameProvided NoNameProvided force-pushed the feat/update-is-phone-number-to-validate-better branch from 9876eea to 782f466 Compare December 15, 2022 21:08
@NoNameProvided NoNameProvided changed the title feat: update IsPhoneNumber decorator to use max dataset feat: update @IsPhoneNumber decorator to use max dataset Dec 15, 2022
@NoNameProvided NoNameProvided merged commit 5f5ece8 into develop Dec 15, 2022
@NoNameProvided NoNameProvided deleted the feat/update-is-phone-number-to-validate-better branch December 15, 2022 21:09
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant