-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added a ISO639-1 decorator #2047
base: develop
Are you sure you want to change the base?
Conversation
This decorator is used to check if a string matches the ISO 639-1, that describes how country languages prefixes should look like. Fortunatelly, it just delegates the validation to an already existent function in the validator library
It would be great if you could update the README.md as well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests as well as update the readme
} | ||
|
||
/** | ||
* Checks if the string is an ISIN (stock/security identifier). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/paste error from other decorator.
@Gustrb Any update on your PR? This looks like a nice addition 😊 |
@te-online, I kind of forgot about it. Will work on adding some tests and fixing the comments pointed out :P |
This decorator is used to check if a string matches the ISO 639-1, that describes how country languages prefixes should look like.
Fortunatelly, it just delegates the validation to an already existent function in the validator library
This PR implements issue #2045