feat: include the current request context when resolving controller from IoC #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pass action through to IocAdapter * make class-validator a peer dependency * make package public * use correct github org * npm scripts for publish * fix readme example * improve type clarity * reuse type definition
|
Stale pull request message |
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
NoNameProvided
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
actionobject is useful when resolving controller instances from the IoC provider, as the context is often used to add additional bindings for objects in a per-request lifecycle scope.This change sends the
actionobject as a second parameter in theget()method that's used when resolving controllers. This has been added as an optional parameter to achieve backwards compatibility.The existing code also assumed that all IoC providers expose this
get()method, which isn't always the case. AnIoCAdapterinterface has been added that can be implemented by consumers who use other providers.Lastly the
class-validatorlibrary has been split into apeer-dependencywhich closes #384