Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CFAbstractStore#methodValues to CFAbstractStore#methodCallExpressions #6562

Merged
merged 14 commits into from May 4, 2024

Conversation

jyoo980
Copy link
Contributor

@jyoo980 jyoo980 commented May 1, 2024

@mernst change to a better name, as discussed in our meeting today.

@jyoo980 jyoo980 requested review from mernst and smillst May 1, 2024 02:21
mernst
mernst previously approved these changes May 1, 2024
Copy link
Member

@mernst mernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things:

  • This merits a mention in the changelog.
  • This will appear in the next release (tentatively 3.43.1 on June 3), so please assign it to Suzanne to merge when the current release is done.

@jyoo980
Copy link
Contributor Author

jyoo980 commented May 2, 2024

@smillst assigning you to merge, now that the previous release is complete.

mernst
mernst previously approved these changes May 2, 2024
smillst
smillst previously approved these changes May 3, 2024
Copy link
Member

@smillst smillst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts and then this can be merged.

@smillst smillst removed their assignment May 3, 2024
@jyoo980 jyoo980 dismissed stale reviews from smillst and mernst via ae7e557 May 3, 2024 15:19
smillst
smillst previously approved these changes May 3, 2024
@smillst smillst enabled auto-merge (squash) May 3, 2024 15:33
@jyoo980
Copy link
Contributor Author

jyoo980 commented May 3, 2024

Will fix after I'm done running some tests locally

@smillst smillst merged commit 150f30e into typetools:master May 4, 2024
28 checks passed
@jyoo980 jyoo980 deleted the yoo/refactor-methodValues branch May 8, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants