Fix potential exponential behavior in obligation tracking in Must Cal… #6567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l Inference; fixes #6566
msridhar
previously approved these changes
May 1, 2024
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class FuzzyEngine { |
There was a problem hiding this comment.
Just checking, did you confirm that without your fix, you see the exponential behavior on this input when running the inference regression tests?
There was a problem hiding this comment.
Yes, and without the fix I was encountering OOM in my machine.
|
@mernst does the CI failure on this PR look like flakiness to you? |
mernst
previously approved these changes
May 2, 2024
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
...ker/src/main/java/org/checkerframework/checker/resourceleak/MustCallConsistencyAnalyzer.java
Outdated
Show resolved
Hide resolved
Yes. Errors in "junit_jdk11" and "junit_jdk17" without an error in "junit_jdk21" are almost always CI flakiness. Suzanne and I have not yet figured it out, but I can click the "rerun" button. (For now, there are two minor typos to fix.) |
msridhar
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l Inference; fixes #6566