Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore to include newline #876

Closed
wants to merge 1 commit into from
Closed

Update .gitignore to include newline #876

wants to merge 1 commit into from

Conversation

cristobal
Copy link

Add newline to satisfy source controls systems such as Github and other automated build tools that add newline at the end of file. Otherwise we end up having people commiting this file to the repo when there's no real change.

So when i run npm install and having the husky install as part of the postinstall script it will overwrite the existing husky files even if they were already installed, or if a new collaborator comes to the team and runs npm install they will now have their .husky/.gitignore overwritten e.g.:

Screenshot 2021-02-16 at 22 41 43

Add newline to satisfy source controls systems such as Github and other automated build tools that add newline at the end of file.
Otherwise we end up having people commiting this file to the repo when there's no real change.
@cristobal
Copy link
Author

Not sure what made the CI fail here 🤷🏽‍♂️

@cristobal
Copy link
Author

Duplicate of #870

@cristobal cristobal closed this Feb 16, 2021
@cristobal cristobal deleted the patch-1 branch February 16, 2021 22:34
@typicode
Copy link
Owner

Hi @cristobal,

How could I reproduce the issue locally?

@cristobal
Copy link
Author

@typicode no worries this is solved in #870, just what @valtlai mentioned:

It’s a very common practice to have a newline at the end of a file. I think Husky should align with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants