Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

universal-cau-thesis:0.1.0 #678

Merged
merged 10 commits into from
May 27, 2024
Merged

universal-cau-thesis:0.1.0 #678

merged 10 commits into from
May 27, 2024

Conversation

JWangL5
Copy link
Contributor

@JWangL5 JWangL5 commented May 20, 2024

I am submitting

  • a new package
  • an update for a package

Description: universal-cau-thesis is a typst thesis template for China Agricultural University.

I have read and followed the submission guidelines and, in particular, I

  • selected a name that isn't the most obvious or canonical name for what the package does
  • added a typst.toml file with all required keys
  • added a README.md with documentation for my package
  • have chosen a license and added a LICENSE file or linked one in my README.md
  • tested my package locally on my system and it worked
  • excluded PDFs or README images, if any, but not the LICENSE
  • ensured that my package is licensed such that users can use and distribute the contents of its template directory without restriction, after modifying them through normal use.

@JWangL5 JWangL5 changed the title CAU-ThesisTemplate-Typst:0.1.0 universal-cau-thesis:0.1.0 May 20, 2024
@JWangL5 JWangL5 closed this May 20, 2024
@JWangL5 JWangL5 reopened this May 20, 2024
@JWangL5
Copy link
Contributor Author

JWangL5 commented May 25, 2024

Thanks for your kind reviews. I have already changed the code as suggestion above. If there's still anything need to be fixed, please let me know.

@elegaanz
Copy link
Contributor

Hello. Thank you for taking the remarks into account.

A few more things. First, I think the font files should not be committed here. If I understand correctly, your README tells to clone your own repository and copy the fonts from here, so having them in this repository will not be useful, and only bloats it with large files. Can you delete them please? I should have asked for that in my previous comment, sorry.
And the second thing is about the template/sample.pdf file, which should be deleted too, as it would currently be copied to each new project based on your template, which you probably don't want.

After that, it should be good to merge. :)

@JWangL5
Copy link
Contributor Author

JWangL5 commented May 27, 2024

OK, I have already deleted them.

@elegaanz
Copy link
Contributor

Thank you!

@elegaanz elegaanz merged commit 8be679d into typst:main May 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants