Fix implicit_getter false positive in case of unknown accessors (re…

…alm#5300)
u-abyss · Dec 16, 2023 · 6a4920d · 6a4920d
1 parent b91df18
commit 6a4920d
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -54,6 +54,10 @@
 
 #### Bug Fixes
 
+* Fix false positive in `implicit_getter` rule when using unknown accessors.  
+  [kabiroberai](https://github.com/kabiroberai)
+  [#5300](https://github.com/realm/SwiftLint/issues/5300)
+
 * Fix correction of `explicit_init` rule by keeping significant trivia.  
   [BB9z](https://github.com/BB9z)
   [#5289](https://github.com/realm/SwiftLint/issues/5289)

diff --git a/Source/SwiftLintBuiltInRules/Rules/Style/ImplicitGetterRule.swift b/Source/SwiftLintBuiltInRules/Rules/Style/ImplicitGetterRule.swift
@@ -30,8 +30,8 @@ private enum ViolationKind {
 private extension ImplicitGetterRule {
     final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> {
         override func visitPost(_ node: AccessorBlockSyntax) {
-            guard let getAccessor = node.getAccessor,
-                  node.setAccessor == nil,
+            guard node.accessorsList.count == 1,
+                  let getAccessor = node.getAccessor,
                   getAccessor.effectSpecifiers == nil,
                   getAccessor.modifier == nil,
                   getAccessor.attributes.isEmpty == true,

diff --git a/Source/SwiftLintBuiltInRules/Rules/Style/ImplicitGetterRuleExamples.swift b/Source/SwiftLintBuiltInRules/Rules/Style/ImplicitGetterRuleExamples.swift
@@ -30,6 +30,24 @@ struct ImplicitGetterRuleExamples {
                 }
             }
             """),
+        Example("""
+            class Foo {
+                var foo: Int {
+                    get { _foo }
+                    _modify { yield &_foo }
+                }
+            }
+            """),
+        Example("""
+            class Foo {
+                var _foo: Int
+                var foo: Int {
+                    @storageRestrictions(initializes: _foo)
+                    init { _foo = newValue }
+                    get { _foo }
+                }
+            }
+            """),
         Example("""
             class Foo {
                 var foo: Int

diff --git a/Source/SwiftLintCore/Models/RuleConfigurationDescription.swift b/Source/SwiftLintCore/Models/RuleConfigurationDescription.swift
@@ -397,7 +397,7 @@ public struct ConfigurationElement<T: AcceptableByConfigurationElement & Equatab
     /// The wrapper itself providing access to all its data. This field can only be accessed by the
     /// element's name prefixed with a `$`.
     public var projectedValue: ConfigurationElement {
-        get { self } // swiftlint:disable:this implicit_getter
+        get { self }
         _modify { yield &self }
     }