Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/package install warnings #325

Merged

Conversation

andrewstec
Copy link
Contributor

Warnings would be produced during yarn install command when no lockfile was used during the installation:

info No lockfile found.
[1/5] Validating package.json...
[2/5] Resolving packages...
warning workspace-aggregator-f34e4066-738c-4aea-a55c-2d330f1bb603 > autotest > xunit-viewer@5.2.0: xunit viewer has been upgraded to v6
warning workspace-aggregator-f34e4066-738c-4aea-a55c-2d330f1bb603 > portal-backend > xunit-viewer@5.2.0: xunit viewer has been upgraded to v6
warning workspace-aggregator-f34e4066-738c-4aea-a55c-2d330f1bb603 > portal-backend > supertest > superagent@3.8.3: Please note that v5.0.1+ of superagent removes User-Agent header by default, therefore you may need to add it yourself (e.g. GitHub blocks requests without a User-Agent header).  This notice will go away with v5.0.2+ once it is released.
warning workspace-aggregator-f34e4066-738c-4aea-a55c-2d330f1bb603 > autotest > xunit-viewer > babel-core > babel-register > core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
warning workspace-aggregator-f34e4066-738c-4aea-a55c-2d330f1bb603 > autotest > xunit-viewer > babel-core > babel-runtime > core-js@2.6.11: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
[3/5] Fetching packages...
info fsevents@1.2.11: The platform "linux" is incompatible with this module.
info "fsevents@1.2.11" is an optional dependency and failed compatibility check. Excluding it from installation.
[4/5] Linking dependencies...
warning Ignored scripts due to flag.
[5/5] Building fresh packages...

Sha.js issue will be resolved here: ubccpsctech#99

@andrewstec
Copy link
Contributor Author

Here is the Yarn installation from the current Docker container build:

image

@rtholmes
Copy link
Contributor

@andrewstec will CircleCI run on this PR automatically?

Copy link
Member

@winstan winstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine...
But some of these changes don't do anything.... ^2.0.5 should be the same as ^2.0.8 and also ^4 the same as ^4.41.5... (caret meaning update to the latest minor version)

@andrewstec
Copy link
Contributor Author

@andrewstec will CircleCI run on this PR automatically?

Hi Reid. It did: https://circleci.com/gh/ubccpsctech/classy/1217.

It looks like CircleCI did not send back the information to Github. If I re-run it, it will likely fix this PR pre-req.

@andrewstec
Copy link
Contributor Author

Fine...
But some of these changes don't do anything.... ^2.0.5 should be the same as ^2.0.8 and also ^4 the same as ^4.41.5... (caret meaning update to the latest minor version)

In the case of "@types/supertest": "^2.0.8",, we could revert that line for the reason you said above.

In the other case, the more verbose convention is more widely used in the package.json file. Those were exceptions to the rule. They do not have to change though.

@andrewstec
Copy link
Contributor Author

CircleCI is currently re-running to fix the pre-req status on this PR.

@winstan
Copy link
Member

winstan commented Feb 10, 2020

Fine...
But some of these changes don't do anything.... ^2.0.5 should be the same as ^2.0.8 and also ^4 the same as ^4.41.5... (caret meaning update to the latest minor version)

In the case of "@types/supertest": "^2.0.8",, we could revert that line for the reason you said above.

In the other case, the more verbose convention is more widely used in the package.json file. Those were exceptions to the rule. They do not have to change though.

I'm happy without any changes. :)

@andrewstec andrewstec merged commit bf58bfd into ubccpsc:master Feb 19, 2020
@andrewstec andrewstec deleted the feature/package-install-warnings branch June 16, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants