Skip to content

Commit

Permalink
Bump honnef.co/go/tools from 0.4.2 to 0.4.3 in /tools (#1056)
Browse files Browse the repository at this point in the history
Bumps [honnef.co/go/tools](https://github.com/dominikh/go-tools) from
0.4.2 to 0.4.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/dominikh/go-tools/releases">honnef.co/go/tools's
releases</a>.</em></p>
<blockquote>
<h2>Staticcheck 2023.1.3 (v0.4.3)</h2>
<p>This release fixes the following bugs:</p>
<ul>
<li>A crash when embedding type aliases of unnamed types (<a
href="https://staticcheck.io/issues/1361">issue 1361</a>)</li>
<li>A false positive in U1000, claiming that type aliases are unused (<a
href="https://staticcheck.io/issues/1365">issue 1365</a>)</li>
<li>A bug in the binary formatter that prevented correct merging
behavior for some checks (<a
href="https://staticcheck.io/issues/1372">issue 1372</a>)</li>
</ul>
<h2>Staticcheck 2023.1.2 (v0.4.2)</h2>
<p>This release fixes a bug that prevented the <code>binary</code>
formatter from working (<a
href="https://staticcheck.io/issues/1370">issue 1370</a>).</p>
<h2>Staticcheck 2023.1.1 (v0.4.1)</h2>
<p>This release fixes a crash, a false positive in U1000 (<a
href="https://staticcheck.io/issues/1360">issue 1360</a>) and improves
the way deprecated API is flagged (<a
href="https://staticcheck.io/issues/1318">issue 1318</a>).</p>
<p>When targeting a Go version that is older than the version that
deprecated an API, <a
href="https://staticcheck.io/docs/checks/#SA1019">SA1019</a> will no
longer flag the use even if there is already an alternative available in
the targeted Go version.</p>
<p>For example, <code>math/rand.Seed</code> has been deprecated in Go
1.20, but an alternative has existed since Go 1.0. In the past, we would
flag uses of <code>Seed</code> even if targeting e.g. Go 1.19, to
encourage better forwards compatibility. This can lead to unnecessary
churn, however, because the correct change may depend on the Go version
in use. For example, for <code>Seed</code> before Go 1.20, the
alternative is to use a separate instance of
<code>math/rand.Rand</code>, whereas in Go 1.20, a possible alternative
is to simply drop the call to <code>Seed</code>.</p>
<h2>Staticcheck 2023.1 (v0.4.0)</h2>
<p>Staticcheck 2023.1 adds support for Go 1.20, brings minor
improvements to various checks, and replaces U1000 with a new
implementation.</p>
<p>The following checks have been improved:</p>
<ul>
<li>The wording of <a
href="https://staticcheck.io/docs/checks/#S1001">S1001</a> has been made
clearer for cases involving arrays. Furthermore, it no longer suggests
using copy when the function has been shadowed.</li>
<li><a href="https://staticcheck.io/docs/checks/#S1011">S1011</a> now
recognizes index-based loops (<a
href="https://staticcheck.io/issues/881">issue 881</a>).</li>
<li><a href="https://staticcheck.io/docs/checks/#SA1019">SA1019</a> no
longer flags tests (internal or external) that use deprecated API from
the package under test (<a
href="https://staticcheck.io/issues/1285">issue 1285</a>). Furthermore,
entire declaration groups (such as groups of constants) can now be
marked as deprecated (<a href="https://staticcheck.io/issues/1313">issue
1313</a>).</li>
<li><a href="https://staticcheck.io/docs/checks/#SA4017">SA4017</a> now
detects more functions, including those in the time package (<a
href="https://staticcheck.io/issues/1353">issue 1353</a>). Additionally,
its wording has been made clearer.</li>
<li><a href="https://staticcheck.io/docs/checks/#SA5010">SA5010</a> no
longer gets confused by type assertions involving generic types (<a
href="https://staticcheck.io/issues/1354">issue 1354</a>).</li>
<li><a href="https://staticcheck.io/docs/checks/#ST1005">ST1005</a> no
longer flags errors that start with alpha-numeric acronyms such as
P384.</li>
<li>Improvements to our intermediate representation may allow various
checks to find more problems.</li>
</ul>
<p>Staticcheck now knows about version 2 of the k8s.io/klog package, in
particular which functions abort control flow (<a
href="https://staticcheck.io/issues/1307">issue 1307</a>).</p>
<p>In addition to these minor improvements, U1000 has been rewritten
from the ground up, operating on a program representation more suited to
the task. In practice this means that there will be fewer false
positives and more true positives.</p>
<p>Overall, the rewrite fixes at least eight known bugs, both ones that
have been a nuisance for a while, as well as ones newly introduced by
generics (<a href="https://staticcheck.io/issues/507">issue 507</a>, <a
href="https://staticcheck.io/issues/633">issue 633</a>, <a
href="https://staticcheck.io/issues/810">issue 810</a>, <a
href="https://staticcheck.io/issues/812">issue 812</a>, <a
href="https://staticcheck.io/issues/1199">issue 1199</a>, <a
href="https://staticcheck.io/issues/1249">issue 1249</a>, <a
href="https://staticcheck.io/issues/1282">issue 1282</a>, <a
href="https://staticcheck.io/issues/1333">issue 1333</a>).</p>
<h2>Staticcheck 2022.1.2 (v0.3.2)</h2>
<p>This release addresses the following false positives, crashes,
infinite loops, and performance issues:</p>
<ul>
<li>For certain packages that contain tens of thousands of types and
methods, such as those generated by <a
href="https://github.com/openconfig/ygot">ygot</a>, Staticcheck now
finishes <a
href="https://redirect.github.com/openconfig/featureprofiles/pull/181#issuecomment-1119250596">much
faster</a>.</li>
<li>Several infinite loops when handling recursive type parameters have
been fixed</li>
<li><a href="https://staticcheck.io/docs/checks/#S1009">S1009</a> no
longer mistakes user-defined functions named <code>len</code> for the
builtin (<a href="https://staticcheck.io/issues/1181">issue
1181</a>)</li>
<li><a href="https://staticcheck.io/docs/checks/#ST1015">ST1015</a> no
longer reorders <code>switch</code> statements if their order is
significant due to the use of <code>fallthrough</code> (<a
href="https://staticcheck.io/issues/1188">issue 1188</a>)</li>
<li><a href="https://staticcheck.io/docs/checks/#SA1013">SA1013</a> now
detects constants more robustly, avoiding both false negatives and false
positives. Furthermore, it makes sure that offending methods implement
io.Seeker and doesn’t just rely on the name Seek (<a
href="https://staticcheck.io/issues/1213">issue 1213</a>).</li>
<li><a href="https://staticcheck.io/docs/checks/#SA5008">SA5008</a> now
understands more third-party extensions to json struct tags</li>
<li>A crash involving functions named <code>_</code> has been fixed (<a
href="https://staticcheck.io/issues/1268">issue 1268</a>)</li>
<li>A crash involving slicing type parameters of type <code>string |
[]byte</code> has been fixed (<a
href="https://staticcheck.io/issues/1270">issue 1270</a>)</li>
<li><a href="https://staticcheck.io/docs/checks/#SA1019">SA1019</a> now
handles imports of deprecated standard library packages in the same way
it handles other deprecated API, taking the targeted Go version into
consideration (<a href="https://staticcheck.io/issues/1117">issue
1117</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/dominikh/go-tools/commit/0e3cc2963b37ac5d3fb66a4d9cb9dcfadbd4e21d"><code>0e3cc29</code></a>
Version 2023.1.3 (v0.4.3)</li>
<li><a
href="https://github.com/dominikh/go-tools/commit/3768a1e4280805f79929ea1caf5d89a2dd8bc907"><code>3768a1e</code></a>
website: add 2023.1.3 release notes</li>
<li><a
href="https://github.com/dominikh/go-tools/commit/9aa5199c318d4a35497b8baf57e3b03d0cdea4bf"><code>9aa5199</code></a>
lintcmd: export fields necessary for gob encoding, again</li>
<li><a
href="https://github.com/dominikh/go-tools/commit/3cd466ffb78cb61adfca762db3b355ee23ff7ac2"><code>3cd466f</code></a>
unused: handle embedded aliases</li>
<li>See full diff in <a
href="https://github.com/dominikh/go-tools/compare/v0.4.2...v0.4.3">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=honnef.co/go/tools&package-manager=go_modules&previous-version=0.4.2&new-version=0.4.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sung Yoon Whang <sungyoon@uber.com>
  • Loading branch information
dependabot[bot] and sywhang committed Mar 27, 2023
1 parent f4f627a commit 99d5ce6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion tools/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/bwplotka/mdox v0.9.0
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
golang.org/x/tools v0.7.0
honnef.co/go/tools v0.4.2
honnef.co/go/tools v0.4.3
)

require (
Expand Down
4 changes: 2 additions & 2 deletions tools/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -1111,8 +1111,8 @@ honnef.co/go/tools v0.0.0-20190523083050-ea95bdfd59fc/go.mod h1:rf3lG4BRIbNafJWh
honnef.co/go/tools v0.0.1-2019.2.3/go.mod h1:a3bituU0lyd329TUQxRnasdCoJDkEUEAqEt0JzvZhAg=
honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
honnef.co/go/tools v0.4.2 h1:6qXr+R5w+ktL5UkwEbPp+fEvfyoMPche6GkOpGHZcLc=
honnef.co/go/tools v0.4.2/go.mod h1:36ZgoUOrqOk1GxwHhyryEkq8FQWkUO2xGuSMhUCcdvA=
honnef.co/go/tools v0.4.3 h1:o/n5/K5gXqk8Gozvs2cnL0F2S1/g1vcGCAx2vETjITw=
honnef.co/go/tools v0.4.3/go.mod h1:36ZgoUOrqOk1GxwHhyryEkq8FQWkUO2xGuSMhUCcdvA=
pack.ag/amqp v0.8.0/go.mod h1:4/cbmt4EJXSKlG6LCfWHoqmN0uFdy5i/+YFz+fTfhV4=
pack.ag/amqp v0.11.0/go.mod h1:4/cbmt4EJXSKlG6LCfWHoqmN0uFdy5i/+YFz+fTfhV4=
rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
Expand Down

0 comments on commit 99d5ce6

Please sign in to comment.