Skip to content

Commit

Permalink
Add Name() to Logger (#1273)
Browse files Browse the repository at this point in the history
Adds the `Name()` function to `Logger`, which will return the logger's name, if configured.
  • Loading branch information
rexywork committed May 7, 2023
1 parent 1155ed3 commit 24b7977
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 6 additions & 0 deletions logger.go
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@ func (log *Logger) Core() zapcore.Core {
return log.core
}

// Name returns the Logger's underlying name,
// or an empty string if the logger is unnamed.
func (log *Logger) Name() string {
return log.name
}

func (log *Logger) clone() *Logger {
copy := *log
return &copy
Expand Down
6 changes: 4 additions & 2 deletions logger_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -340,15 +340,17 @@ func TestLoggerNames(t *testing.T) {
}
log.Info("")
require.Equal(t, 1, logs.Len(), "Expected only one log entry to be written.")
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name.")
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name from entry.")
assert.Equal(t, tt.expected, log.Name(), "Unexpected logger name.")
})
withSugar(t, DebugLevel, nil, func(log *SugaredLogger, logs *observer.ObservedLogs) {
for _, n := range tt.names {
log = log.Named(n)
}
log.Infow("")
require.Equal(t, 1, logs.Len(), "Expected only one log entry to be written.")
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name.")
assert.Equal(t, tt.expected, logs.AllUntimed()[0].LoggerName, "Unexpected logger name from entry.")
assert.Equal(t, tt.expected, log.base.Name(), "Unexpected logger name.")
})
}
}
Expand Down

0 comments on commit 24b7977

Please sign in to comment.