Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if EncodeLevel is set to avoid nil pointer dereference #1058

Merged
merged 2 commits into from Feb 4, 2022
Merged

Check if EncodeLevel is set to avoid nil pointer dereference #1058

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a921815
Check if EncodeLevel is set to avoid nil pointer dereference
aerosol Feb 4, 2022
c2a7c3a
Update zapcore/json_encoder_test.go
abhinav Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion zapcore/json_encoder.go
View file
Open in desktop
Expand Up @@ -364,7 +364,7 @@ func (enc *jsonEncoder) EncodeEntry(ent Entry, fields []Field) (*buffer.Buffer,
final := enc.clone()
final.buf.AppendByte('{')

if final.LevelKey != "" {
if final.LevelKey != "" && final.EncodeLevel != nil {
final.addKey(final.LevelKey)
cur := final.buf.Len()
final.EncodeLevel(ent.Level, final)
Expand Down
30 changes: 30 additions & 0 deletions zapcore/json_encoder_test.go
View file
Open in desktop
Expand Up @@ -136,6 +136,36 @@ func TestJSONEncodeEntry(t *testing.T) {
}
}

func TestNoEncodeLevelSupplied(t *testing.T) {

abhinav marked this conversation as resolved.
Show resolved Hide resolved
enc := zapcore.NewJSONEncoder(zapcore.EncoderConfig{
MessageKey: "M",
LevelKey: "L",
TimeKey: "T",
NameKey: "N",
CallerKey: "C",
FunctionKey: "F",
StacktraceKey: "S",
EncodeTime: zapcore.ISO8601TimeEncoder,
EncodeDuration: zapcore.SecondsDurationEncoder,
EncodeCaller: zapcore.ShortCallerEncoder,
})

ent := zapcore.Entry{
Level: zapcore.InfoLevel,
Time: time.Date(2018, 6, 19, 16, 33, 42, 99, time.UTC),
LoggerName: "bob",
Message: "lob law",
}

fields := []zapcore.Field{
zap.Int("answer", 42),
}

_, err := enc.EncodeEntry(ent, fields)
assert.NoError(t, err, "Unexpected JSON encoding error.")
}

func TestJSONEmptyConfig(t *testing.T) {
tests := []struct {
name string
Expand Down