Logger, SugaredLogger: Add Level method #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav
force-pushed
the
abg/logger-level
branch
2 times, most recently
from
85fa6f1
to
46c3194
Compare
abhinav
force-pushed
the
abg/logger-level
branch
from
46c3194
to
edd44a2
Compare
|
Ready for review now that LevelOf has been released. |
abhinav
force-pushed
the
abg/logger-level
branch
from
edd44a2
to
9cecbb8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 49 49
Lines 2163 2165 +2
=======================================
+ Hits 2127 2129 +2
Misses 28 28
Partials 8 8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Aug 24, 2022
mway
approved these changes
Aug 29, 2022
|
Hi @abhinav! I was wondering when there is going to be a new release including the new |
|
Hey @anitasec, I'll probably cut a new release on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
Level() Levelmethod on Logger and SugaredLoggerthat reports the current minimum enabled log level for the logger.
This relies on the zapcore.LevelOf function added in #1147.
Resolves #1144
Depends on #1147