Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] zapgrpc.Logger implements Experimental DepthLoggerV2 #1268

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2023

CLA assistant check
All committers have signed the CLA.

@forsaken628 forsaken628 changed the title [Feature] zapgrpc.Logger implements Experimental DepthLoggerV2 [Feature] zapgrpc.Logger implements Experimental DepthLoggerV2 (#1267) Apr 5, 2023
@forsaken628 forsaken628 changed the title [Feature] zapgrpc.Logger implements Experimental DepthLoggerV2 (#1267) [Feature] zapgrpc.Logger implements Experimental DepthLoggerV2 Apr 5, 2023
@sywhang
Copy link
Contributor

sywhang commented May 5, 2023

@forsaken628 thanks for the submission, do you have any additional info on why this is needed on Zap's side? The issue you created doesn't have most of its fields filled out properly.

@forsaken628
Copy link
Author

The current zapgrpc package is poorly maintained and outdated. This PR just fills in the parts that this package should have. Or zapgrpc should be marked as deprecated.

@frbvianna
Copy link

Any updates on this? It definitely looks like zapgrpc package is outdated compared to grpc-go-middleware past version, the grpclog verbosity level variable GRPC_GO_LOG_VERBOSITY_LEVEL currently does not seem to be working at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants