[draft/wip] Adding (initial) fortio.org/log entry #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abhinav
reviewed
Aug 18, 2023
Comment on lines
+38
to
+39
| // Go optimizes away allocations for numbers below 256 | ||
| _tenInts = []int{1001, 1002, 1003, 1004, 1005, 1006, 1007, 1008, 1009, 1010} |
There was a problem hiding this comment.
Fair point. If you're still experimenting with this PR, you can probably get this specific change merged as a separate PR.
There was a problem hiding this comment.
thanks btw, how / on which machine do you run make updatereadme as the absolute (and seemingly even some times the relative numbers) depends on the hw/arch/os it's being ran on ?
There was a problem hiding this comment.
I think original runs were on Intel Macbook Pros, and since then on Apple Silicon Macbook Pros.
Absolute numbers are less important than the relative performance, so as long as the numbers are consistent and the benchmarks were all run on the same machine, it should be good to check-in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
make updatereadmeandgo test -v -bench="." -benchtime=3s -benchmemon my M1 max laptopUsing this to improve and compare fortio's logger perf