Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer: Fix AppendBytes doc string #1362

Merged
merged 1 commit into from
Sep 18, 2023
Merged

buffer: Fix AppendBytes doc string #1362

merged 1 commit into from
Sep 18, 2023

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Sep 18, 2023

Bad copy-paste; AppendBytes appends all the given bytes,
not just one byte.

Thanks to @makkes for catching this.

Bad copy-paste; AppendBytes appends all the given bytes,
not just one byte.

Thanks to @makkes for catching this.
@abhinav abhinav enabled auto-merge (squash) September 18, 2023 12:04
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #1362 (da6fbf2) into master (8a14570) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1362   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          53       53           
  Lines        3493     3493           
=======================================
  Hits         3438     3438           
  Misses         46       46           
  Partials        9        9           
Files Changed Coverage Δ
buffer/buffer.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mway mway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhinav abhinav merged commit 4ddf010 into uber-go:master Sep 18, 2023
6 checks passed
Copy link

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants