Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fmt: Prefer gofumpt over gofmt #1366

Merged
merged 1 commit into from
Sep 30, 2023
Merged

fmt: Prefer gofumpt over gofmt #1366

merged 1 commit into from
Sep 30, 2023

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Sep 30, 2023

Switches to gofumpt for code formatting instead of gofmt.

This is a slightly stricter formatter and addresses common nits
such as extraneous empty lines at start and end of functions,
missing empty lines between functions,
unnecessary or missing var groups,
etc.

Switches to gofumpt for code formatting instead of gofmt.

This is a slightly stricter formatter and addresses common nits
such as extraneous empty lines at start and end of functions,
missing empty lines between functions,
unnecessary or missing var groups,
etc.
@abhinav abhinav enabled auto-merge (squash) September 30, 2023 15:56
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Merging #1366 (08eb76f) into master (2f09c51) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
- Coverage   98.42%   98.28%   -0.15%     
==========================================
  Files          53       53              
  Lines        3493     3493              
==========================================
- Hits         3438     3433       -5     
- Misses         46       50       +4     
- Partials        9       10       +1     
Files Coverage Δ
zapgrpc/zapgrpc.go 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav merged commit ed7ddb5 into uber-go:master Sep 30, 2023
6 checks passed
@abhinav abhinav deleted the gofumpt branch September 30, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants