Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename license file to satisfy go docs for nested modules #1389

Merged
merged 1 commit into from
Nov 27, 2023

Commits on Nov 27, 2023

  1. Rename license file to satisfy go docs for nested modules

    The documentation for module `uber.go/zap/exp` is not eligible to be
    rendered on pkg.go.dev as no license is detected. For example,
    https://pkg.go.dev/go.uber.org/zap/exp@v0.2.0/zapslog will not render.
    
    This is due to some possibly unfortunate behavior in the Go command that
    special cases copying a `LICENSE` file from the repository for root for
    any nested modules lacking a `LICENSE` file. This is problematic for Zap
    as Zap's license is in a file named `LICENSE.txt`. Renaming the license
    file to `LICENSE` remedies the issue.
    
    Relevant issues:
    - golang/go#43817 (comment)
    - golang/go#44758 (comment)
    lrewega committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    b006e20 View commit details
    Browse the repository at this point in the history