Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: support additional content type #903

Merged
merged 6 commits into from Feb 2, 2021

Commits on Jan 8, 2021

  1. http: support additional content type

    Support `application/x-www-form-urlencoded` as an additional content
    type for `AtomicLevel.ServeHTTP`.
    
    This is the default content type for `curl -X POST`.
    
    With this change, interacting with the HTTP endpoint is a bit more
    user friendly:
    
    ```
    curl -X PUT localhost:8080/log/level -d level=debug
    ```
    
    Additionally, the unit tests for the HTTP handler are transformed to
    a table driven approach.
    
    fixes uber-go#902
    oncilla committed Jan 8, 2021
    Copy the full SHA
    756d507 View commit details
    Browse the repository at this point in the history
  2. cover more error branches

    oncilla committed Jan 8, 2021
    Copy the full SHA
    794c2df View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. feedback

    oncilla committed Jan 11, 2021
    Copy the full SHA
    e1be881 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. decode*: Turn into functions

    These methods do not have need of the atomic level. Turn them into
    functions to avoid accidentally manipulating or accessing it.
    abhinav committed Jan 15, 2021
    Copy the full SHA
    6fe8012 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. use Request.FormValue

    oncilla committed Jan 25, 2021
    Copy the full SHA
    870ced4 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Copy the full SHA
    86ae38e View commit details
    Browse the repository at this point in the history