Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov token #921

Merged
merged 1 commit into from Feb 23, 2024
Merged

Add codecov token #921

merged 1 commit into from Feb 23, 2024

Conversation

yuxincs
Copy link
Collaborator

@yuxincs yuxincs commented Feb 23, 2024

We have upgraded our codecov upload action to v4. However, tokenless uploads are unsupported now (see codecov/codecov-action#1293). This PR fixes the config to give the action a codecov token stored in repository secrets.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (3fc9b8a) to head (198b3d2).
Report is 13 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #921      +/-   ##
============================================
+ Coverage     86.98%   87.09%   +0.10%     
- Complexity     1959     1990      +31     
============================================
  Files            77       77              
  Lines          6330     6430     +100     
  Branches       1223     1245      +22     
============================================
+ Hits           5506     5600      +94     
- Misses          420      422       +2     
- Partials        404      408       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix!

@yuxincs yuxincs merged commit 28cc318 into master Feb 23, 2024
12 checks passed
@yuxincs yuxincs deleted the yuxincs/add-codecov-token branch February 23, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants