Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: default Jest testing configuration #19

Merged
merged 4 commits into from
Mar 4, 2024
Merged

feat: default Jest testing configuration #19

merged 4 commits into from
Mar 4, 2024

Conversation

gentlementlegen
Copy link
Collaborator

Resolves #15

@ubiquibot-continuous-deploys
Copy link

ubiquibot-continuous-deploys bot commented Mar 4, 2024 •
edited

@gentlementlegen
Copy link
Collaborator Author

The issue seems to be the same as the other repositories, that the GITHUB_TOKEN is not allowed to do any write operations and fails on Knip, and on posting Jest coverage results to the pull request. Currently the token has the following permissions:

GITHUB_TOKEN Permissions
  Actions: read
  Checks: read
  Contents: read
  Deployments: read
  Discussions: read
  Issues: read
  Metadata: read
  Packages: read
  Pages: read
  PullRequests: read
  RepositoryProjects: read
  SecurityEvents: read
  Statuses: read

0x4007
0x4007 reviewed Mar 4, 2024
View reviewed changes
jest.config.js Outdated Show resolved Hide resolved
0x4007
0x4007 reviewed Mar 4, 2024
View reviewed changes
package.json Show resolved Hide resolved
@molecula451 molecula451 merged commit f0c06fb into ubiquity:development Mar 4, 2024
2 of 3 checks passed
@gentlementlegen gentlementlegen deleted the feat/default-testing-setup branch March 5, 2024 02:10
@ubiquibot ubiquibot bot mentioned this pull request Mar 5, 2024
Closed
@0x4007
Copy link
Member

0x4007 commented Mar 5, 2024

The issue seems to be the same as the other repositories, that the GITHUB_TOKEN is not allowed to do any write operations and fails on Knip, and on posting Jest coverage results to the pull request. Currently the token has the following permissions:

GITHUB_TOKEN Permissions
  Actions: read
  Checks: read
  Contents: read
  Deployments: read
  Discussions: read
  Issues: read
  Metadata: read
  Packages: read
  Pages: read
  PullRequests: read
  RepositoryProjects: read
  SecurityEvents: read
  Statuses: read

You're free to fix knip too as gitcoindev is occupied with a high priority and large project https://www.github.com/ubiquity/ubiquity-dollar/issues/752

@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@molecula451 molecula451 molecula451 approved these changes

@0x4007 0x4007 0x4007 approved these changes

@rndquu rndquu rndquu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing into repository template
4 participants
@gentlementlegen @0x4007 @molecula451 @rndquu