Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: decouple paned view from master detail #897

Merged
merged 3 commits into from
May 15, 2024

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented May 15, 2024

Decouple the paned view and resizing feature from master details widget, so we can use it as a standalone.
I also fixed the resizing region hover animation color flash bug, and added a lot of tests.

Capture.video.du.2024-05-15.14-39-06.webm

@Jupi007
Copy link
Member Author

Jupi007 commented May 15, 2024

Here is a capture of the resize zone animation bug:

Capture.video.du.2024-05-15.14-44-25.webm

@Jupi007 Jupi007 added this to the 5.0 milestone May 15, 2024
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice! Also a nice step to make this "giant" widget a bit less giant. (The list could also be extracted to create different layouts like drawers... Not in this pr ofc)

@Jupi007
Copy link
Member Author

Jupi007 commented May 15, 2024

Fully agree, this widget is way too big!
I wanted to decouple the resizing feature since a long time.
I will try to refactor it a little bit more in another PR!

@Jupi007 Jupi007 merged commit f006d8e into ubuntu:main May 15, 2024
7 checks passed
@Jupi007 Jupi007 deleted the yaru-panned branch May 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants