New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some electron based applications use a white menu background color #715
Comments
Hi thanks for reporting. Both are based on electron, and are now using gtk3 =) Doesn't reduce the fact that they have the wrong color ofc :) |
That's an anomaly I see when on communitheme snap with some applications,Gtk2 apps included. While trying to change theme some parts of communitheme are still present. It looks like a bug in snap session. |
@Paz-it yes, using snap session. I'll try gnome session and Ubuntu session with XORG \ Wayland. Report here soon. |
@Paz-it same results in all sessions. New informations:
Arc Darker: i installed ubuntu 2 days ago. New information: VS Code in ElementaryOS after upgrade, changed the toolbar to the inverse color, like in communittheme. Maybe is a electron issue? |
Have you tried rebooting Gnome shell? Those might be server side decorations that don't go away otherwise |
@clobrano yes. Rebooted gnome shell in every change using "r". Also rebooted the system too. Problem persist. |
@otavioschwanck Ok, @Paz-it you did the same? |
The menus are also white with the .deb version of atom. But maybe we should first check if "they" really suck up the gtk code for the menus :) |
I'm using a deb version of atom, vscode and franz. |
@clobrano Yes, I did the same. |
I don't understand this... Electron uses GTK3 dialogues now. |
@Feichtmeier when did this change happen? I remember electron apps where styled after gtk2 |
@clobrano some weeks ago |
Weird, because in #728 menu bar works like it's using GTK2 colors |
Prbly because they didn't merge the newer electron code yet :D But anyways I don't know why for example atom, which clearly uses the gtk3 filechoser , doesnt use our menu colour |
not sure if I understood. Who changed the toolbar? |
However, electron project opened a bug about this and there's a PR in progress, so I guess it's an upstream issue |
I'd say let's close this here then? :) If it's handled upstream |
The fix was merged electron/electron#14785 |
@clobrano |
Since the fix is in electron let's close it here |
Atom and Visual Studio Code have a white toolbat, making very ugly to look.
Other GTK 2 applications like franz, work nice:
But, when try to change theme to adwaita, it have a black toolbar, even when i restart the application.
The text was updated successfully, but these errors were encountered: