-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplified spreadsheet export #229
Conversation
…e docs directory, improve doc builder (filtering out SAWarning), and move some overly specific text from the spreadsheet download page to the help.
Failing on numpy safety checks. One affects "all version", though (">0") -- not fixable, therefore disable this safety check? Its concern is numpy/numpy#19038. Adding "--ignore 44715" might fix this (not sure where it goes) -- could do that for a few others too, or move the minimum Python version to 3.8 as numpy 1.22.0 isn't available for 3.7. |
I'd do what I did for CRATE and stick with 3.7 and numpy 1.21. The ignores go in https://github.com/RudolfCardinal/camcops/blob/simplified_spreadsheet_export/.github/workflows/push-to-repository.yml#L59 We may find some of the warnings go away on Tuesday when the vulnerability database is updated. |
Thanks; trying again... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good from a code review perspective. I haven't tried it out yet.
There's a dependency conflict in my virtualenv kombu 5.2.3 has requirement amqp<6.0.0,>=5.0.9, but you have amqp 5.0.6.
and I need to check if that is just my stale environment. I'll look into the build failures also.
I have kombu==5.2.2 -- it's not in setup.py, so I guess we should pin that (but do feel free to bump everything to your higher versions!). |
azure.archive.ubuntu.com is having issues actions/runner-images#675
azure.archive.ubuntu.com is having issues actions/runner-images#675
I rebuilt my virtualenv with the latest pip and now I don't have any broken dependencies |
Good to merge from my point of view. I did a quick test and it seems to be working as expected. |
Thanks! |
Addresses #228.