Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force specific locale #1528

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Force specific locale #1528

wants to merge 3 commits into from

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Jun 19, 2023

This fixes issues like

[ERROR] Failed to execute goal org.eclipse.steady:plugin-maven:@@PROJECT_VERSION@@:app (default-cli) on project xxxxx: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters: shapeless/$tilde$qmark$greater$?.class

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

geekLucian added a commit to riscv-hdc/chipyard_deprecated that referenced this pull request Jan 3, 2024
geekLucian added a commit to riscv-hdc/chipyard_deprecated that referenced this pull request Jan 3, 2024
@joonho3020
Copy link
Contributor

Should we move the corresponding env-vars into env.sh?

@joonho3020
Copy link
Contributor

@jerryz123 @abejgonzalez

@jerryz123
Copy link
Contributor Author

Should we move the corresponding env-vars into env.sh?

That is probably a better solution, if at all, than this PR.

We didn't merge this because this didn't actually fix the problem in all cases.

@joonho3020
Copy link
Contributor

Hmm I see, I guess we can bring this up in the next cy meeting

@jerryz123
Copy link
Contributor Author

You can close this PR and make it a issue if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants