Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update submodule with elimEta fix #1608

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

yiyunliu
Copy link
Collaborator

@yiyunliu yiyunliu commented Feb 9, 2020

I did include a negative test file which returns exit code 1 for the fixed elimEta and 2 for the buggy one. However, I need to test Wen's example before this can be safely merged.

@yiyunliu
Copy link
Collaborator Author

For some reason circleci didn't checkout the updated submodule..

@nikivazou
Copy link
Member

For some reason circleci didn't checkout the updated submodule..

@adinapoli didn't you fix that?

@adinapoli
Copy link
Collaborator

@nikivazou I've stumbled into something similar (i.e. the submodule fetching weirdness representing itself) while working on the GHC 8.10 patch.

I think my original fix was incomplete, because we have to crucially install ssh and git before checking out the code. Apologies for not noticing this sooner! I was going to eventually submit a fix as part of my ghc-8.10 branch, but as this might not land for a while, I will issue the one line fix to hopefully fix this for good. Sorry again!

@adinapoli
Copy link
Collaborator

Hopefully this PR should fix things for the better 🤞 #1610

@nikivazou nikivazou reopened this Feb 12, 2020
@nikivazou
Copy link
Member

@yiyunliu can you merge develop to this to check that it is ok?

Thanks!

@facundominguez
Copy link
Collaborator

@nikivazou, would you like getting this PR merged, or should we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants